From: Parav Pandit <parav@nvidia.com>
To: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>, <cohuck@redhat.com>
Cc: <sgarzare@redhat.com>, <pasic@linux.ibm.com>,
<david.edmondson@oracle.com>,
<virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
Parav Pandit <parav@nvidia.com>
Subject: [virtio-dev] [PATCH v16 06/11] transport-mmio: Avoid referring to zero based index
Date: Thu, 4 May 2023 05:29:54 +0300 [thread overview]
Message-ID: <20230504022959.547025-7-parav@nvidia.com> (raw)
In-Reply-To: <20230504022959.547025-1-parav@nvidia.com>
VQ range is already described in the first patch in basic virtqueue
section. Hence remove the duplicate reference to it.
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
Acked-by: Halil Pasic <pasic@linux.ibm.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
---
changelog:
v12->v13:
- corrected number to index
v11->v12:
- remove changes related to 'vq number'
v8->v9:
- added 'by' at two places
- replaced 'queue number' with 'vq number'
v6->v7:
- remove text around first vq as it is already covered in the basic
virtqueues facility section
---
transport-mmio.tex | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/transport-mmio.tex b/transport-mmio.tex
index 164e640..2d24b4c 100644
--- a/transport-mmio.tex
+++ b/transport-mmio.tex
@@ -113,8 +113,7 @@ \subsection{MMIO Device Register Layout}\label{sec:Virtio Transport Options / Vi
following operations on \field{QueueSizeMax},
\field{QueueSize}, \field{QueueReady},
\field{QueueDescLow}, \field{QueueDescHigh}, \field{QueueDriverlLow}, \field{QueueDriverHigh},
- \field{QueueDeviceLow}, \field{QueueDeviceHigh} and \field{QueueReset} apply to. The index
- number of the first queue is zero (0x0).
+ \field{QueueDeviceLow}, \field{QueueDeviceHigh} and \field{QueueReset} apply to.
}
\hline
\mmioreg{QueueSizeMax}{Maximum virtual queue size}{0x034}{R}{%
@@ -363,8 +362,7 @@ \subsubsection{Virtqueue Configuration}\label{sec:Virtio Transport Options / Vir
The driver will typically initialize the virtual queue in the following way:
\begin{enumerate}
-\item Select the queue writing its index (first queue is 0) to
- \field{QueueSel}.
+\item Select the queue by writing its index to \field{QueueSel}.
\item Check if the queue is not already in use: read \field{QueueReady},
and expect a returned value of zero (0x0).
@@ -474,9 +472,7 @@ \subsection{Legacy interface}\label{sec:Virtio Transport Options / Virtio Over M
Writing to this register selects the virtual queue that the
following operations on the \field{QueueSizeMax},
\field{QueueSize}, \field{QueueAlign}
- and \field{QueuePFN} registers apply to. The index
- number of the first queue is zero (0x0).
-.
+ and \field{QueuePFN} registers apply to.
}
\hline
\mmioreg{QueueSizeMax}{Maximum virtual queue size}{0x034}{R}{%
@@ -550,8 +546,7 @@ \subsection{Legacy interface}\label{sec:Virtio Transport Options / Virtio Over M
The virtual queue is configured as follows:
\begin{enumerate}
-\item Select the queue writing its index (first queue is 0) to
- \field{QueueSel}.
+\item Select the queue by writing its index to \field{QueueSel}.
\item Check if the queue is not already in use: read \field{QueuePFN},
expecting a returned value of zero (0x0).
--
2.26.2
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-05-04 2:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 2:29 [virtio-dev] [PATCH v16 00/11] Rename queue number to queue index Parav Pandit
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 01/11] content: Add vq index text Parav Pandit
2023-05-04 14:20 ` [virtio-dev] " David Edmondson
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 02/11] content.tex Replace virtqueue number with index Parav Pandit
2023-05-04 14:20 ` [virtio-dev] " David Edmondson
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 03/11] content: Rename confusing queue_notify_data and vqn names Parav Pandit
2023-05-04 14:28 ` [virtio-dev] " David Edmondson
2023-05-04 18:33 ` [virtio-dev] " Parav Pandit
2023-05-04 18:49 ` [virtio-dev] " Michael S. Tsirkin
2023-05-04 19:00 ` [virtio-dev] " Parav Pandit
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 04/11] transport-pci: Avoid first vq index reference Parav Pandit
2023-05-04 14:28 ` [virtio-dev] " David Edmondson
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 05/11] transport-mmio: Rename QueueNum register Parav Pandit
2023-05-04 2:29 ` Parav Pandit [this message]
2023-05-04 14:29 ` [virtio-dev] Re: [PATCH v16 06/11] transport-mmio: Avoid referring to zero based index David Edmondson
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 07/11] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 08/11] transport-ccw: Refer to the vq by its index Parav Pandit
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 09/11] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 10/11] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-05-04 14:30 ` [virtio-dev] " David Edmondson
2023-05-04 2:29 ` [virtio-dev] [PATCH v16 11/11] virtio-net: Update vqn to vq_index for cvq cmds Parav Pandit
2023-05-04 14:31 ` [virtio-dev] " David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230504022959.547025-7-parav@nvidia.com \
--to=parav@nvidia.com \
--cc=cohuck@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox