[virtio-dev] Re: [PATCH v16 02/11] content.tex Replace virtqueue number with index

David Edmondson
2023-05-04T14:26:22Z

Parav Pandit <parav@nvidia.com> writes:

> Replace virtqueue number with index to align to rest of the
> specification.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
>

Reviewed-by: David Edmondson <david.edmondson@oracle.com>

> ---
> changelog:
> v11->v12:
> - new patch
> ---
> content.tex | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/content.tex b/content.tex
> index 9b694f2..9cf938c 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -406,7 +406,7 @@ \section{Driver Notifications} \label{sec:Basic Facilities of a Virtio Device /
>
> When VIRTIO_F_NOTIFICATION_DATA has not been negotiated,
> this notification involves sending the
> -virtqueue number to the device (method depending on the transport).
> +virtqueue index to the device (method depending on the transport).
>
> However, some devices benefit from the ability to find out the
> amount of available data in the queue without accessing the virtqueue in memory:
> @@ -790,13 +790,13 @@ \chapter{Reserved Feature Bits}\label{sec:Reserved Feature Bits}
> buffer notifications.
> As mentioned in section \ref{sec:Basic Facilities of a Virtio Device / Driver notifications}, when the
> driver is required to send an available buffer notification to the device, it
> - sends the virtqueue number to be notified. The method of delivering
> + sends the virtqueue index to be notified. The method of delivering
> notifications is transport specific.
> With the PCI transport, the device can optionally provide a per-virtqueue value
> - for the driver to use in driver notifications, instead of the virtqueue number.
> + for the driver to use in driver notifications, instead of the virtqueue index.
> Some devices may benefit from this flexibility by providing, for example,
> an internal virtqueue identifier, or an internal offset related to the
> - virtqueue number.
> + virtqueue index.
>
> This feature indicates the availability of such value. The definition of the
> data to be provided in driver notification and the delivery method is
> --
> 2.26.2
--
There's someone in my head but it's not me.