From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17E73C7EE22 for ; Tue, 9 May 2023 15:15:22 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 0C09016E5A8 for ; Tue, 9 May 2023 15:15:22 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id E1D1D98656B for ; Tue, 9 May 2023 15:15:21 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id C9CAC986542; Tue, 9 May 2023 15:15:21 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id B7B33986546 for ; Tue, 9 May 2023 15:15:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: ouQnsEseNYGDdb21s4F1zw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683645318; x=1686237318; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xI0401wP+xvLSV7mgAJKIOuzttpl7/ohCO2AR9DIlyM=; b=SdKy94GoyZlQk6MYy7/km+yCIoL4qKluP8ip5aNluiGINzIIylfNwy+30mDcjayCPf 9RdjgEPHuUjkEz587IhzoB+2CHOdKehhcwsMHb22nH7671VdQpxSJBxaVpC4eDqZRbhO AUIlr/dDdYjawQ9FcU3MuEBGHHUWSAoUJEWoClx5kv4wpNLc5sYbQNuWsIA7M9ucVC5V rF42+Uvz158vJbUSSXeKgLs5/nK4qSXfRsjRYgsBwthN16LHPnb8S6vaiCh8IHJKhKKA qARnMhB7NFjNip5iMC7i2UQ6PaKMo+mIZ2x9AXw4sl/qs744XgBBK2CHKNt+SS0f9z23 7Tpw== X-Gm-Message-State: AC+VfDw6J530PIQW1pEFSBe54VGHUubdZlnMK3ZH/QZCAPLLq/cecBc5 2au7dZUV24ahMfTiaiuLefBXZ9FXCA3GBJHxU7/b0gPnbUepHJ4IHJS3ECPqbNtvG3nLP1bU6cf y5KOaweJuVIHFzl++zg56HkBEsUeD X-Received: by 2002:a1c:ed13:0:b0:3f1:6fb3:ffd4 with SMTP id l19-20020a1ced13000000b003f16fb3ffd4mr9325447wmh.6.1683645317912; Tue, 09 May 2023 08:15:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7gyp+BfDIbOsIPkebg+KQNrI3kqCqD2HgzeTdqgnKc4g8zwu9zPCfdjnAO2UoKq2cwFUkh6w== X-Received: by 2002:a1c:ed13:0:b0:3f1:6fb3:ffd4 with SMTP id l19-20020a1ced13000000b003f16fb3ffd4mr9325428wmh.6.1683645317594; Tue, 09 May 2023 08:15:17 -0700 (PDT) Date: Tue, 9 May 2023 11:15:13 -0400 From: "Michael S. Tsirkin" To: Heng Qi Cc: virtio-dev@lists.oasis-open.org, virtio-comment@lists.oasis-open.org, Parav Pandit , Jason Wang , Yuri Benditovich , Xuan Zhuo Message-ID: <20230509110941-mutt-send-email-mst@kernel.org> References: <20230423073532.105636-1-hengqi@linux.alibaba.com> <20230425165659-mutt-send-email-mst@kernel.org> <19e6d4e6-e3d8-7eca-4d54-d113b4cc5504@linux.alibaba.com> <20230426104538-mutt-send-email-mst@kernel.org> <5463159d-daa2-101b-6abf-ea7aa4f40bd0@linux.alibaba.com> <20230427130008-mutt-send-email-mst@kernel.org> <20230505135115.GA110622@h68b04307.sqa.eu95> <20230505105427-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Subject: Re: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [PATCH v13] virtio-net: support inner header hash On Tue, May 09, 2023 at 10:22:19PM +0800, Heng Qi wrote: > > > 在 2023/5/5 下午10:56, Michael S. Tsirkin 写道: > > On Fri, May 05, 2023 at 09:51:15PM +0800, Heng Qi wrote: > > > On Thu, Apr 27, 2023 at 01:13:29PM -0400, Michael S. Tsirkin wrote: > > > > On Thu, Apr 27, 2023 at 10:28:29AM +0800, Heng Qi wrote: > > > > > > > > > > 在 2023/4/26 下午10:48, Michael S. Tsirkin 写道: > > > > > > On Wed, Apr 26, 2023 at 10:14:30PM +0800, Heng Qi wrote: > > > > > > > This does not mean that every device needs to implement and support all of > > > > > > > these, they can choose to support some protocols they want. > > > > > > > > > > > > > > I add these because we have scale application scenarios for modern protocols > > > > > > > VXLAN-GPE/GENEVE: > > > > > > > > > > > > > > +\item In scenarios where the same flow passing through different tunnels is expected to be received in the same queue, > > > > > > > + warm caches, lessing locking, etc. are optimized to obtain receiving performance. > > > > > > > > > > > > > > > > > > > > > Maybe the legacy GRE, VXLAN-GPE and GENEVE? But it has a little crossover. > > > > > > > > > > > > > > Thanks. > > > > > > But VXLAN-GPE/GENEVE can use source port for entropy. > > > > > > > > > > > > It is recommended that the UDP source port number > > > > > > be calculated using a hash of fields from the inner packet > > > > > > > > > > > > That is best because > > > > > > it allows end to end control and is protocol agnostic. > > > > > Yes. I agree with this, I don't think we have an argument on this point > > > > > right now.:) > > > > > > > > > > For VXLAN-GPE/GENEVE or other modern tunneling protocols, we have to deal > > > > > with > > > > > scenarios where the same flow passes through different tunnels. > > > > > > > > > > Having them hashed to the same rx queue, is hard to do via outer headers. > > > > > > All that is missing is symmetric Toepliz and all is well? > > > > > The scenarios above or in the commit log also require inner headers. > > > > Hmm I am not sure I get it 100%. > > > > Could you show an example with inner header hash in the port #, > > > > hash is symmetric, and you still have trouble? > > > > > > > > > > > > It kinds of sounds like not enough entropy is not the problem > > > > at this point. > > > Sorry for the late reply. :) > > > > > > For modern tunneling protocols, yes. > > > > > > > You now want to drop everything from the header > > > > except the UDP source port. Is that a fair summary? > > > > > > > For example, for the same flow passing through different VXLAN tunnels, > > > packets in this flow have the same inner header and different outer > > > headers. Sometimes these packets of the flow need to be hashed to the > > > same rxq, then we can use the inner header as the hash input. > > > > > > Thanks! > > So, they will have the same source port yes? > > Yes. The outer source port can be calculated using the 5-tuple of the > original packet, > and the outer ports are the same but the outer IPs are different after > different directions of the same flow pass through different tunnels. > > Any way to use that > > We use it in monitoring, firewall and other scenarios. > > > so we don't depend on a specific protocol? > > Yes, selected tunneling protocols can be used in this scenario like this. > > Thanks. > No, the question was - can we generalize this somehow then? For example, a flag to ignore source IP when hashing? Or maybe just for UDP packets? -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org