[virtio-dev] Re: [PATCH v13 03/10] admin: introduce group administration commands

Parav Pandit
2023-05-05T16:03:15Z

Hi Michael,

On 5/5/2023 11:40 AM, Michael S. Tsirkin wrote:

> +\field{opcode} specifies the command. The valid
> +values for \field{opcode} can be found in the following table:
> +
> +\begin{tabular}{|l|l|}
> +\hline
> +opcode & Name & Command Description \\
> +\hline \hline
> +0x0000 - 0x7FFF & - & Commands using \field{struct virtio_admin_cmd} \\
> +\hline
> +0x8000 - 0xFFFF & - & Reserved for future commands (possibly using a different structure) \\
> +\hline
> +\end{tabular}
> +
> +The \field{group_type} specifies the group type identifier.
> +The \field{group_member_id} specifies the member identifier within the group.
> +See section \ref{sec:Introduction / Terminology / Device group}
> +for the definition of the group type identifier and group member
> +identifier.
> +
> +The \field{status} describes the command result and possibly
> +failure reason at an abstract level, this is appropriate for
> +forwarding to applications. The \field{status_qualifier} describes
> +failures at a low virtio specific level, as appropriate for debugging.
> +The following table describes possible \field{status} values;
> +to simplify common implementations, they are intentionally
> +matching common \hyperref[intro:errno]{Linux error names and numbers}:
> +
> +\begin{tabular}{|l|l|l|}
> +\hline
> +Status (decimal) & Name & Description \\
> +\hline \hline
> +00 & VIRTIO_ADMIN_STATUS_OK & successful completion \\
> +\hline
> +11 & VIRTIO_ADMIN_STATUS_EAGAIN & try again \\
> +\hline
> +12 & VIRTIO_ADMIN_STATUS_ENOMEM & insufficient resources \\
> +\hline
> +22 & VIRTIO_ADMIN_STATUS_EINVAL & invalid command \\
> +\hline
> +other & - & group administration command error \\
> +\hline
> +\end{tabular}
> +
> +When \field{status} is VIRTIO_ADMIN_STATUS_OK, \field{status_qualifier}
> +is reserved and set to zero by the device.
> +
> +The following table describes possible \field{status_qualifier} values:
> +\begin{tabular}{|l|l|l|}
> +\hline
> +Status & Name & Description \\
> +\hline \hline
> +0x00 & VIRTIO_ADMIN_STATUS_Q_OK & used with VIRTIO_ADMIN_STATUS_OK \\
> +\hline
> +0x01 & VIRTIO_ADMIN_STATUS_Q_INVALID_COMMAND & command error: no additional information \\
> +\hline
> +0x02 & VIRTIO_ADMIN_STATUS_Q_INVALID_OPCODE & unsupported or invalid \field{opcode} \\
> +\hline
> +0x03 & VIRTIO_ADMIN_STATUS_Q_INVALID_FIELD & unsupported or invalid field within \field{command_specific_data} \\
> +\hline
> +0x04 & VIRTIO_ADMIN_STATUS_Q_INVALID_GROUP & unsupported or invalid \field{group_type} \\
> +\hline
> +0x05 & VIRTIO_ADMIN_STATUS_Q_INVALID_MEMBER & unsupported or invalid \field{group_member_id} \\
> +\hline
> +0x06 & VIRTIO_ADMIN_STATUS_Q_NORESOURCE & out of internal resources: ok to retry \\
> +\hline
> +0x07 & VIRTIO_ADMIN_STATUS_Q_TRYAGAIN & command blocks for too long: should retry \\
> +\hline
> +0x08-0xFFFF & - & reserved for future use \\
> +\hline
> +\end{tabular}

Did you miss taking my 3 changes here I posted at [1]?
https://lists.oasis-open.org/archives/virtio-comment/202304/msg00532.html

Or you sent some older version by mistake?

or they got fixed in some later hunk in this series?

Without this changes pdf generation is broken and manual intervention of
script generates pdf table which is messed up.

It is not too late, to fix and resend quickly.

Or probably list down the known issues and I will create the follow up
patches as these are mandatory non cosmetic editorial changes.

Please let me know how shall we proceed.