public inbox for virtio-dev@lists.linux.dev
 help / color / mirror / Atom feed
From: Heng Qi <hengqi@linux.alibaba.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtio-dev@lists.oasis-open.org,
	virtio-comment@lists.oasis-open.org,
	Jason Wang <jasowang@redhat.com>, Parav Pandit <parav@nvidia.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [virtio-dev] Re: [Proposal] Relationship between XDP and rx-csum in virtio-net
Date: Tue, 23 May 2023 10:41:18 +0800	[thread overview]
Message-ID: <20230523024118.GA23504@h68b04307.sqa.eu95> (raw)
In-Reply-To: <20230522150743-mutt-send-email-mst@kernel.org>

On Mon, May 22, 2023 at 03:10:05PM -0400, Michael S. Tsirkin wrote:
> On Mon, May 22, 2023 at 08:12:00PM +0800, Heng Qi wrote:
> > 1) Add a feature bit to the virtio specification to tell the sender that a fully
> > csumed packet must be sent.
> 
> Who is the sender in this picture? The driver?

The device or the driver.

When the device is hw, the sender is more likely to be a device.
When the device is sw, the sender can be a device or a driver.

But in general, this feature is inclined to constrain the behavior of the device and
the driver from the receiving side.

For example: 
VIRTIO_NET_F_UNNECESSARY_CSUM : The driver tells the device that you must send me a fully csumed packet.

Then the specific implementation can be

(1) the sender sends a fully csumed packet;
(2) the receiver receives a CHECKSUM_PARTIAL packet, and the device helps calculate the fully csum
    (because the two parties in the communication are located on the same host, the packet is trusted.).

In summary, if VIRTIO_NET_F_UNNECESSARY_CSUM is negotiated, the driver will no longer receive any packets marked CHECKSUM_PARTIAL.

Thanks.

> 
> -- 
> MST

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2023-05-23  2:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22 12:12 [virtio-dev] [Proposal] Relationship between XDP and rx-csum in virtio-net Heng Qi
2023-05-22 19:10 ` [virtio-dev] " Michael S. Tsirkin
2023-05-23  2:41   ` Heng Qi [this message]
2023-05-23  7:15     ` Michael S. Tsirkin
2023-05-23  9:18       ` Heng Qi
2023-05-23 13:30         ` Michael S. Tsirkin
2023-05-23 13:51           ` [virtio-dev] Re: [virtio-comment] " Heng Qi
2023-05-24  4:09             ` Jason Wang
2023-05-24  5:07               ` [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [Proposal] Relationship between XDP and rx-csum in virtio-nety Heng Qi
2023-05-24  5:52                 ` Jason Wang
2023-05-24  7:24                   ` Heng Qi
2023-05-26  7:58                     ` [virtio-dev] Re: [virtio-comment] " Heng Qi
2023-05-24  5:17               ` [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [Proposal] Relationship between XDP and rx-csum in virtio-net Heng Qi
2023-05-24  6:07             ` Michael S. Tsirkin
2023-05-24  8:12               ` Heng Qi
2023-05-30 19:33                 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-05-31  6:57                   ` Heng Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230523024118.GA23504@h68b04307.sqa.eu95 \
    --to=hengqi@linux.alibaba.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox