From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF4ABC77B73 for ; Tue, 6 Jun 2023 11:56:33 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 0EC4A192317 for ; Tue, 6 Jun 2023 11:56:33 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id EF9269864D2 for ; Tue, 6 Jun 2023 11:56:32 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id DE7B1986495; Tue, 6 Jun 2023 11:56:32 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id C4CDC986491 for ; Tue, 6 Jun 2023 11:56:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: MMF3O-_wMYqOOaTOW-wH6g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686052588; x=1688644588; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/T2TrVAwgcB2zfHrxJ7W31FGRJv6qqLr2dDl+ExGtsE=; b=Pz/LUVu9Wjecv7gyxz34A0QfdQT4XpuZL4mNR/xkFs7Ce8gEwoJA3xW4VN1EmI+vdW qziX8tUsVyVO+Jes8GNLeSs9j1GGYJmsSkqT4QJRv1PNduLt4EVxbR23Xz2ggJOddi3A VgJKlwOQCHtiMDvBUAOKJAzaQqDL+K94/2vkL82yYnetQ/MWnWOiJ/3SxwrC3LLaACD0 ZDSejm+NrSwL4RTQtVbZ/SGKjtMBc6+7X2QznCgljbv/y9D6kcF0jCaiC4Y6udhL9wRu x8NMzHjhpT1j8PktcHNpHEXUnt4hF1DZ1w2rftWdvOAZ/StcSaXflz8V8R4Z43eg0yWc E9zQ== X-Gm-Message-State: AC+VfDxx+CrqUKaIBjaFbdovUqwY3c6p36KFQdCOGQCNYYY5Rkj+5UOf 0Ugxegl4ISj/K05Q4L19gEOrvGa8wClyXcPh+cTvoLgs22C4cEtsezjzB55Fxl8EAebozQTIyeO iLytk9VKDmbHFWsGDg/EV/ycue6xL X-Received: by 2002:a5d:608c:0:b0:30e:5284:cbc4 with SMTP id w12-20020a5d608c000000b0030e5284cbc4mr689213wrt.68.1686052588497; Tue, 06 Jun 2023 04:56:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4/51ogCfsn2ofiSH1Evj9KKSPcB+86tsY5bpcalitMy20NsLLFFL0iyRhBCegMJ2enx4Nj1A== X-Received: by 2002:a5d:608c:0:b0:30e:5284:cbc4 with SMTP id w12-20020a5d608c000000b0030e5284cbc4mr689201wrt.68.1686052588169; Tue, 06 Jun 2023 04:56:28 -0700 (PDT) Date: Tue, 6 Jun 2023 07:56:23 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: "virtio-dev@lists.oasis-open.org" , "cohuck@redhat.com" , "david.edmondson@oracle.com" , "sburla@marvell.com" , "jasowang@redhat.com" , Yishai Hadas , Maor Gottlieb , "virtio-comment@lists.oasis-open.org" , Shahaf Shuler Message-ID: <20230606073544-mutt-send-email-mst@kernel.org> References: <20230604105027-mutt-send-email-mst@kernel.org> <20230604174224-mutt-send-email-mst@kernel.org> <20230605014539-mutt-send-email-mst@kernel.org> <20230605092859-mutt-send-email-mst@kernel.org> <20230605174755-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: Re: [virtio-dev] Re: [PATCH v3 0/3] transport-pci: Introduce legacy registers access using AQ On Mon, Jun 05, 2023 at 10:12:59PM +0000, Parav Pandit wrote: > Rolling v4 now. Great thanks! I think the result will be in a good shape from the ABI point of view. Good job! I think so far Jason was the only one with significant comments on the series so let's see what he says. >From my personal POV what will be left to do to get this feature ready for merging would be - tightening the language: - thinking of and addressing all kind of corner cases. Since by now from our email discussions I have I think a decent understanding of how the feature is supposed to work I understand how these things work but I think there are still things that would be a bit unclear for an unprepared reader. Just to give a random example, there's no explicit time where the member kind of switches to the legacy/back to modern mode. I am guessing setting DRIVER bit through legacy interface does this. We'll want to list that. I'll try to help find these issues and maybe even suggest wording. I've delayed commenting on these until the high level design is agreed on, didn't want to make you waste time on polishing as the patches undergo significant changes, and I suggest you do the same in v4: let's make sure there's a wide agreement on the ABI then focus on the spec language. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org