From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95EACC7EE45 for ; Thu, 8 Jun 2023 19:00:56 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id F42036A78D for ; Thu, 8 Jun 2023 19:00:55 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id EB2D0986692 for ; Thu, 8 Jun 2023 19:00:55 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id DE34B986681; Thu, 8 Jun 2023 19:00:55 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id CD4CD986686 for ; Thu, 8 Jun 2023 19:00:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: p_Ll6O7nM_qGVWBknVfX9w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686250850; x=1688842850; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n5Em1Yln+NUCKcxkgs9tdjKPowP2IUMRO6kM6uFd94M=; b=i7ZX9iMLZa2QiP5GEohTm8FaIYBuSBLcjBBGNJPpuw0AvBPe+Ht2YVJKiElZNg44lx eFhQdBYR/4uxXUaOQ3iCAliVUACnAOzULTdHYj50J8YlTPUPu9Gc9acmtvCaDjjoir1L 9eKirdagjBWXzFWkk7XW+Y9RMnY693wfMdCto666EFjDJuKK+06mU1F6nAYoAkec2sa5 QaLEM0KS1rqEQCI4Ipk3RuHzy76g0P/YTDrmVTXUwftyCfvil2Oe4u+pHq5tKFv27l8Z Y+LJuT9e0RBJBoiVNKn2encYmRfRsupbtv3E4Mswu9Yk17C+8/h6MDk+IwqOuKsMBe01 aBuw== X-Gm-Message-State: AC+VfDxvew095XwRPF0IMi9UXkuDfGVdFpKJyPIJyyCmiRfkotP8wYE6 n4g7enJUzunlZNKrvsSW20vDkyTzgdssGHxGQHmp5u3nApYWyOQiIcdGcFeyQir8Xa1RLcSmKoc 1MSTjZVCjLyLXlUgr/Nf63BMpvXiS X-Received: by 2002:a05:6000:1972:b0:301:8551:446a with SMTP id da18-20020a056000197200b003018551446amr8052512wrb.2.1686250850665; Thu, 08 Jun 2023 12:00:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7X46aETPCkXem1pv8jkeQaiOSTZvLlRgxPUX77mTo1/+s8Upi9/Hcjb2hGP8WUf9SD3La2eA== X-Received: by 2002:a05:6000:1972:b0:301:8551:446a with SMTP id da18-20020a056000197200b003018551446amr8052495wrb.2.1686250850379; Thu, 08 Jun 2023 12:00:50 -0700 (PDT) Date: Thu, 8 Jun 2023 15:00:45 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: "virtio-dev@lists.oasis-open.org" , "cohuck@redhat.com" , "david.edmondson@oracle.com" , "sburla@marvell.com" , "jasowang@redhat.com" , Yishai Hadas , Maor Gottlieb , "virtio-comment@lists.oasis-open.org" , Shahaf Shuler Message-ID: <20230608145944-mutt-send-email-mst@kernel.org> References: <20230602203604.627661-1-parav@nvidia.com> <20230602203604.627661-3-parav@nvidia.com> <20230608143135-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [PATCH v3 2/3] transport-pci: Introduce legacy registers access commands On Thu, Jun 08, 2023 at 06:55:29PM +0000, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Thursday, June 8, 2023 2:34 PM > > > > +0x0003 & VIRTIO_ADMIN_CMD_LCC_REG_READ & Read legacy common > > configuration registers of a member device \\ > > > +\hline > > > +0x0004 & VIRTIO_ADMIN_CMD_LD_REG_WRITE & Write legacy device > > registers of a member device \\ > > > +\hline > > > +0x0005 & VIRTIO_ADMIN_CMD_LD_REG_READ & Read legacy device > > registers of a member device \\ > > > +\hline > > > +0x0006 & VIRTIO_ADMIN_CMD_LQ_NOTIFY_QUERY & Read the queue > > > +notification offset for legacy interface \\ \hline > > > > Could you avoid such drastic abbreviation in command names? > > Standard things like CMD,CFG are ok, but LCC/LD will not ring any bells for > > anyone, except maybe confusingly make one think of "C Compiler" and "Link > > eDitor". > > Let's just LEGACY_COMMON_CFG/LEGACY_DEVICE_CFG? > > > It looked too long before abbreviating it. > Will change. > > VIRTIO_ADMIN_CMD_LEGACY_COMMON_REG_READ > VIRTIO_ADMIN_CMD_LEGACY_DEV_REG_READ I think you can drop _REG_ that does not really add any value and does not match anything in the spec. _CFG_ would make sense spec calls this common configuration and device configuration. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org