From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04342C77B7A for ; Tue, 13 Jun 2023 09:02:09 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 3BA4EF3F4B for ; Tue, 13 Jun 2023 09:02:09 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 1B9AD98657F for ; Tue, 13 Jun 2023 09:02:09 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id F251F9842EA; Tue, 13 Jun 2023 09:02:08 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id DD79C98653E for ; Tue, 13 Jun 2023 09:02:08 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: Q7-58exTMKa7c-9T8rZBxg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686646924; x=1689238924; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uXZcdvswDWEbWdRD6Dxm76mmdbRLTnNSDCCm4TfKYJA=; b=iyIqyHLuahBVkVpikhIDIfHq49AI/1QjY13LgCr69gW53eGnQCv2g+OSZ0FSMVVB1n pAVmkoZW2XRqvLMzrA7bBQSynGCZSFYQ7fVp7bTGit06IlR5WiHdsmht8Uhmdg9ztsab PQ7vJ1RN0tiqXYSedtWVNbSwKSiYl4ZurHF6YiayQTWKXFTnPDfijgY7BIwn6K2ZEcBn fywQIAv3zt5HKpIuon6nkR9JoxC3bBc+57u2eTHrmM5fLYYqIGLaXWXbmlLczAzJogrK 9BALo5A4GGP7WjKvE3MNui30Q03EoqZn06glZGfSaKtCv6p2ufgMd/qKmDlhIYVrvSxG M6gg== X-Gm-Message-State: AC+VfDx1F0F1og45ISBICIC7QZw5pMnU8gYbS6JcYl79WwHtQdfcC/IQ zmztE8IgfFXg+In/b/dDhypmisWlIFgh3bCxKhYhqjhmQ0aRBGhZpK0SLyI/FpUiHWDX5wQ+yse NZcgVw5PGKpHfuXfvC8twQNt7VVnc X-Received: by 2002:a17:907:7e9a:b0:94f:3521:394 with SMTP id qb26-20020a1709077e9a00b0094f35210394mr11924641ejc.51.1686646924744; Tue, 13 Jun 2023 02:02:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4AR+Le+qQmjkG9M4cchN753y0H8qIAEEIFtI0ZIKfpflbXhSxVn4pC6sO/F/MuXz0GYznAew== X-Received: by 2002:a17:907:7e9a:b0:94f:3521:394 with SMTP id qb26-20020a1709077e9a00b0094f35210394mr11924618ejc.51.1686646924470; Tue, 13 Jun 2023 02:02:04 -0700 (PDT) Date: Tue, 13 Jun 2023 05:02:01 -0400 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: virtio-dev@lists.oasis-open.org, virtio-comment@lists.oasis-open.org, Parav Pandit , Jason Wang Message-ID: <20230613045854-mutt-send-email-mst@kernel.org> References: <1686550355.2503424-1-xuanzhuo@linux.alibaba.com> <20230612022526-mutt-send-email-mst@kernel.org> <1686569235.2395291-1-xuanzhuo@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: <1686569235.2395291-1-xuanzhuo@linux.alibaba.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [virtio-comment] Re: About custom device counter On Mon, Jun 12, 2023 at 07:27:15PM +0800, Xuan Zhuo wrote: > On Mon, 12 Jun 2023 02:25:42 -0400, "Michael S. Tsirkin" wrote: > > On Mon, Jun 12, 2023 at 02:12:35PM +0800, Xuan Zhuo wrote: > > > We hope to support device custom counter. That is, virtio spec provides a > > > channel for driver and device, and both key and value are provided by device. > > > > > > We discussed this issue earlier, and after some internal practice, I think it is > > > still necessary to discuss this again. > > > > > > It is very important, each cloud vendor will always have some special counters, > > > these counters may not exist in another vendor. At the same time, if we have > > > to discuss it in the spec every time we add a counter, or add a feature, I > > > think it is very inconvenient. Manufacturers may add some new counters at any > > > time based on some new requirements. Some counters may also be removed at any > > > time. > > > > > > Of course I know that doing this might hurt migration. But what I want to say is, > > > why does it affect live migration? These counters we plan to give to users > > > through ethtool -S, and some changes have taken place in the ethtool counters > > > output by users. Does this have any practical impact? Or do we directly use > > > some other output in a way, we can clearly tell the user that these counters > > > may change during the migration process. For example, the driver is migrated > > > to some new devices. These devices support some new counters. I think users > > > should be able to see these new counters. These new counters may be the > > > purpose of the migration. > > > > > > We don't need to support live migration at this point. > > > > > > Thanks. > > > > > > Why not just document the thing? > > Device Counter or Device Stat, we discussed this issue earlier, > So I want to slove the problem migration firstly. > > > Thanks. Sorry have trouble parsing this. Can we get examples of counters from various vendors, so that it's clear what kind of thing this, and it becomes convincing that abstracting this in virtio spec is pointless? Also, am I right assuming that in virtualized settings this is mostly relevant for hosts? E.g. guests see a vendor neutral virtio but host wants to figure out source of issues? > > > > > -- > > MST > > > > > > This publicly archived list offers a means to provide input to the > > OASIS Virtual I/O Device (VIRTIO) TC. > > > > In order to verify user consent to the Feedback License terms and > > to minimize spam in the list archive, subscription is required > > before posting. > > > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org > > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org > > List help: virtio-comment-help@lists.oasis-open.org > > List archive: https://lists.oasis-open.org/archives/virtio-comment/ > > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf > > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists > > Committee: https://www.oasis-open.org/committees/virtio/ > > Join OASIS: https://www.oasis-open.org/join/ > > --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org