From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75164EB64D9 for ; Mon, 19 Jun 2023 16:37:48 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id C626E16DD8E for ; Mon, 19 Jun 2023 16:37:47 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id A26D09864BD for ; Mon, 19 Jun 2023 16:37:47 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 8224F9863A6; Mon, 19 Jun 2023 16:37:47 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 6F27A9863B0 for ; Mon, 19 Jun 2023 16:37:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: r7dBNEiFMJuy2Ms2hHB8HQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687192664; x=1689784664; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X+n8n57WG9+U7TLqIgh/Chvy0opVLo3B0cSG6RjN/9k=; b=VELsuTlcBbyBovmlulIIONtCWWjXUDZ5tjNSjTyr4tHnAjCRApn/jGvCDSrA9OEkNu vq4L8kYpKL5gWnGZoSee+Ae32QJDyn9bM5GLfwZ9ivT6aojl6SYMAvJJ5y5T4hMWVyhl cLRtRqQtC8g0cMZt5bQzh+MCQZUzFZnGW/glYJhMEKM8oEexGoRIy4u00/zT9fdLsz/G 8wbIXV9/bTqpe2azv8akbaS2xpNug5SDSzu1DUVw5DYTMUY7hwiOV7WaIARdJ+ieqC9B YipP1d5i3iiAqyIrKBPu8berh8GHt5w19iXONXhkw/B599/RGp1QIHMjhgGO1X9BFgWQ YWmg== X-Gm-Message-State: AC+VfDwxrDi8nyYks4++pgmil9Q87ZryMUClklSX2xr7CqcT3eFtkCzN U2T2LhUWm35z6+ZiaoAnu6pfQDLj6ibpY8AXFLuvTQe92HwraSddK2JgsfmerJ8p64BshAIRMw/ Qq148KR9MqcI/cIDaE1zBQhWFZaDI X-Received: by 2002:a5d:4c49:0:b0:307:9702:dfc8 with SMTP id n9-20020a5d4c49000000b003079702dfc8mr8738098wrt.48.1687192663707; Mon, 19 Jun 2023 09:37:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ674ZmS4VN/RwcNBGEh3a01b/dUyA9DYgrUky92L/oSrvtFKjJ7CDHc9ru2deB8GeXQvUJZEA== X-Received: by 2002:a5d:4c49:0:b0:307:9702:dfc8 with SMTP id n9-20020a5d4c49000000b003079702dfc8mr8738082wrt.48.1687192663264; Mon, 19 Jun 2023 09:37:43 -0700 (PDT) Date: Mon, 19 Jun 2023 12:37:39 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: virtio-comment@lists.oasis-open.org, cohuck@redhat.com, david.edmondson@oracle.com, virtio-dev@lists.oasis-open.org, sburla@marvell.com, jasowang@redhat.com, yishaih@nvidia.com, maorg@nvidia.com, shahafs@nvidia.com Message-ID: <20230619122836-mutt-send-email-mst@kernel.org> References: <20230613173015.1244486-1-parav@nvidia.com> <20230613173015.1244486-5-parav@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20230613173015.1244486-5-parav@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access On Tue, Jun 13, 2023 at 08:30:15PM +0300, Parav Pandit wrote: > --- a/transport-pci.tex > +++ b/transport-pci.tex > @@ -541,6 +541,8 @@ \subsubsection{Notification structure layout}\label{sec:Virtio Transport Options > struct virtio_pci_notify_cap { > struct virtio_pci_cap cap; > le32 notify_off_multiplier; /* Multiplier for queue_notify_off. */ > + u8 legacy_q_notify_supported; > + u8 reserved[3]; > }; > \end{lstlisting} > > @@ -560,6 +562,14 @@ \subsubsection{Notification structure layout}\label{sec:Virtio Transport Options > the same Queue Notify address for all queues. > \end{note} > > +\field{legacy_q_notify_supported} when set to 1, indicates that the device > +supports legacy queue notifications at this notification location. Legacy Queue > +Notification address is derived within a BAR for a virtqueue: > + > +\begin{lstlisting} > + cap.offset > +\end{lstlisting} > + > \devicenormative{\paragraph}{Notification capability}{Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / Notification capability} > The device MUST present at least one notification capability. > I was hoping that we can avoid touching transport-pci.tex completely, this is why I wanted to reuse VIRTIO_PCI_CAP_NOTIFY_CFG. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org