From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E59CBEB64D9 for ; Mon, 19 Jun 2023 17:11:07 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 2BD9F94EE8 for ; Mon, 19 Jun 2023 17:11:07 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 0B583986430 for ; Mon, 19 Jun 2023 17:11:07 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id E1A229863A6; Mon, 19 Jun 2023 17:11:06 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id CEA9C9863A9 for ; Mon, 19 Jun 2023 17:11:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: VSBiSKG0OGO5BzabEc175Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687194662; x=1689786662; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YqE25GwlpsHbTvjqxQ9vZ9X3YKy8tDRTCmEqkFQoH0k=; b=CrAS9FNJRV0qDJYtEhJpWJpSvo7OxAi8iDVT7R+0wCkLutLNqqvQiLfCWJfQbw6IPZ CzSBGtN2EJ9JYmEbnmBlfeqjX82Rg/8ZEMk2qiJ3PLX1sR1TCoRheITecDWI74DQZSD2 DcdQfsmnpa9vnN2UZJ523oW2anklBTMWkh8tZBABdSVqPPnGiTHs9xTxc1jdYzYw6Jk+ Gl/b/kj9S0RwapANCPW32a+OQ7ag7kirlixlCiwENPLAsY+Vd42YV84iCSJsH5uQKRn2 +b9bVVRKC98KctV5itb7hNplJSzRBh4/RSeSOd/i/oRLf31Kt8rVDyEOH05xgXlur/Fu P0JA== X-Gm-Message-State: AC+VfDywDqtn29fg+R/CnKGMwpefgSFI3MBuJYBz1l3XhXlQ43AoKxVD 4icQDCWa1HnnFv1i+FA12tHWtj+O7wLnqXQ8Qqhd8LP8/lc4VCmO6+6VMu/bnH/4BytE8X+PpiW jTZD9DJnIfqDKPGdpM7vLEIZs1AWv X-Received: by 2002:a7b:c7da:0:b0:3f9:b5cc:71e4 with SMTP id z26-20020a7bc7da000000b003f9b5cc71e4mr297770wmk.8.1687194662213; Mon, 19 Jun 2023 10:11:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5xVEC5w7ZtlW4YTFh+cLPRCH1wBJJUXnxzLS+++209a4JxyKpS5S/zs3JYapUMI+BaPrYjvQ== X-Received: by 2002:a7b:c7da:0:b0:3f9:b5cc:71e4 with SMTP id z26-20020a7bc7da000000b003f9b5cc71e4mr297751wmk.8.1687194661884; Mon, 19 Jun 2023 10:11:01 -0700 (PDT) Date: Mon, 19 Jun 2023 13:10:57 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: "virtio-comment@lists.oasis-open.org" , "cohuck@redhat.com" , "david.edmondson@oracle.com" , "virtio-dev@lists.oasis-open.org" , "sburla@marvell.com" , "jasowang@redhat.com" , Yishai Hadas , Maor Gottlieb , Shahaf Shuler Message-ID: <20230619130440-mutt-send-email-mst@kernel.org> References: <20230613173015.1244486-1-parav@nvidia.com> <20230613173015.1244486-4-parav@nvidia.com> <20230619121724-mutt-send-email-mst@kernel.org> <20230619123757-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [PATCH v6 3/4] admin: Add group member legacy register access commands On Mon, Jun 19, 2023 at 04:45:23PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 12:40 PM > > > > > > > > we can just say "the legacy interface of member devices" > > > > > > > What is the harm in telling explicitly what is currently supported, specially > > when it theory of operation description section. > > > > The harm is that > > - making things generic on the 1st try is the only stick we have > > as contributors always push to make their solutions as > > specific to their needs as possible > > - people are lazy and they will copy text and then I get to repeat this argument > > all over again. > > > > The "legacy interface of member device" is a vague term. As implementer, reader I don't understand what that means. > The commands clearly communicate the scope. Add this as an example then. > > If you want to also have a type specific text, be my guest "specifically, for an > > SRIOV type" .... > > > SRIOV in generic section doesn't make sense. It is covered in the pci transport section. When it's convenient to you you argue that it's clearer, when it's not you want it generic. Just mention it quickly and link to the specific text in the new section. Look the only reason I personally am even entertaining this over objections of several members is that this stuff has the potentional to be well contained. That's the only argument, otherwise individual features like _F_LEGACY_MAC would win hands down - this is how we always did it. If you are intent on spreading this all over the spec we'll need to rethink the whole approach. > > > > > > > using following listed > > > > > > > > using the following > > > > > > > > > +administrative commands: > > > > > > > > administration not administrative > > > > > > > Ack. --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org