From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8894AEB64DB for ; Mon, 19 Jun 2023 17:37:49 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id C88972AFEC for ; Mon, 19 Jun 2023 17:37:47 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 53390986830 for ; Mon, 19 Jun 2023 17:37:47 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 023ED9865D0; Mon, 19 Jun 2023 17:37:47 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id D27D6986429 for ; Mon, 19 Jun 2023 17:37:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: X8Hx5YRoPRupTkXOuJ78ww-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687196263; x=1689788263; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3050zEV9/MzgWmosdTeWPjPE4G3lxcfo4ol+uBaZmBY=; b=PFrKIg1mKf24K3Ms0AmpHbOjvm9RjEKmnQx3/5/bBy+XTRbRZ8UWB37pXBuSBaGwYO 9K1mogTYz+d6GZhDc6gOLmbBbXqN/eO7110W+9SNuk1h/7I3DVH6MJvQDjnXuYJO/YIK UGL2ilJYlVdU01PxHBS/N0+1T7knZXBq/NbBw3NklDC6rO8+HBhckoanGMsu3kkaBJ3d WbJgu4x0cli/q9+YVxEbA+Mr/rN4JxWdo+8/ZzlhRHKOdnG92wFxzs8pKDimZA6qEqs/ hd5xmFeHd/7uFIOXw7gW6dCCaDf/JaOFNyEzOb951vXqXYVXWdv9JK73uihQqfH3uXCO IIpQ== X-Gm-Message-State: AC+VfDy2hSd3cQ8j6kplERGx49GFFTP2A4F70gEzrgIz89CXM9gd2dWT 1vNXjIhqlGpmgR2bttPjTnQZ6jXT42R9qJu8+dwLwKhSp7r5CSPpLsX9msEDiKUHONWUy1Ypefq uJl6bcdlP2LNeQnrV1fce+FEkBJfV X-Received: by 2002:a05:6000:181:b0:311:149c:23fa with SMTP id p1-20020a056000018100b00311149c23famr9050428wrx.25.1687196263635; Mon, 19 Jun 2023 10:37:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5ZDMKvsO1LRlC+KiNquOpszjksSayH1Ky69uDAMpLUMxum8ovlXMJwJ7xTAJSEMBw18PC+lg== X-Received: by 2002:a05:6000:181:b0:311:149c:23fa with SMTP id p1-20020a056000018100b00311149c23famr9050415wrx.25.1687196263326; Mon, 19 Jun 2023 10:37:43 -0700 (PDT) Date: Mon, 19 Jun 2023 13:37:39 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: "virtio-comment@lists.oasis-open.org" , "cohuck@redhat.com" , "david.edmondson@oracle.com" , "virtio-dev@lists.oasis-open.org" , "sburla@marvell.com" , "jasowang@redhat.com" , Yishai Hadas , Maor Gottlieb , Shahaf Shuler Message-ID: <20230619133322-mutt-send-email-mst@kernel.org> References: <20230613173015.1244486-1-parav@nvidia.com> <20230613173015.1244486-5-parav@nvidia.com> <20230619122836-mutt-send-email-mst@kernel.org> <20230619131115-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access On Mon, Jun 19, 2023 at 05:26:22PM +0000, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:20 PM > > > > It is reused, but it doesnt come for free. > > > Do you want to re-consider AQ notify query command? > > > Or continue as proposed in v6? > > > > > > If we can't just make it come for free then maybe > > VIRTIO_PCI_CAP_LEGACY_NOTIFY_CFG is better, we can just list the number in > > the common section and then link to the description in the new section. > > > How is it better? It requires burning more bytes. > Is it better because it is self contained? Mostly yes. But it also adds a bit more flexibility, right? I thought avoiding touching transport-pci is worth less flexibility but if we can't avoid that... > > I also feel we want ability to have such a capability in the owner too. > > Would prefer including it now though I guess we can add it as an extension. > > Re-opening the past discussion.. amazing. :) OK fair enough.. I guess both of us are not 100% happy but it's a compromize for now. And maybe we'll add one of AQ and / or PF cap down the road. > Why? How is it different and better than querying over AQ? Wait a second let me clarify. I am talking about notification in the PCI BAR of the PF. *Not* offset in PF capability but in the VF BAR. > I see the AQ is better than group owner and group member specific cap. --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org