[virtio-dev] Re: [virtio-comment] Re: [PATCH v18] virtio-net: support inner header hash

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Jun 21, 2023 at 07:37:00PM +0000, Parav Pandit wrote:
> 
> 
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Wednesday, June 21, 2023 3:32 PM
> 
> > 
> > Well RSS is designed (imho) better since it keeps the supported types in config
> > space. Doing it here would have removed the need for GET command.
> > Yes I know Parav hates config space, no I don't think for a read-only field like
> > this one this hate is justified.
> > Did we discuss this and decided not to add it in config space for some reason? I
> > don't remember ...
> > 
> Yes, we discussed this in v12 or before to have symmetric interface to have it via get and set via cvq.
> Should be there in the change log.

Oh good point, it is in commit log. Heng Qi, thanks for writing such a
nice detailed commit log!

Here is what you wrote:
	Given that a set command is added via cvq, it make sense to also do 
	symetrric work to get it via a cvq.

and actually I missed the fact that instead of making this
symmetric it forced separate structures for GET and SET.

If we move supported_tunnel_hash_types back to config space
then GET and SET just need the active bitmap. *that* seems
symmetric to me.

And the field is RO so no memory cost to exposing it in all VFs.


-- 
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org