From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAAD6EB64D9 for ; Thu, 29 Jun 2023 19:54:04 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 21A4242566 for ; Thu, 29 Jun 2023 19:54:04 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 023989866EE for ; Thu, 29 Jun 2023 19:54:04 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id DF9AE9865B5; Thu, 29 Jun 2023 19:54:03 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id CC68398667F for ; Thu, 29 Jun 2023 19:54:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: lEaTHf2UM1CBuu5ZFsER_A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688068440; x=1690660440; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RPywTCarUy0hL1UUownwBp3OCFNBDAt+zTaVSRjETCY=; b=ZyBsL5iMe+ln+0gnteeHenIAOoUakMi7rIRuefa1ewpnjs0rPBA17fN9gCqV5TDSlS /HFYonG4XThuea3qBm03t+WiRO9qB5vjF7ooGINz/tF/28htKTrCPmvBEiSAuaPgnqhU rpE823ZXsWB5iqwQMg5GUFjSqrgSZjeILMIRDAnciDLpxdqP2JYBu+7DD+7d5HogbIef qAnRwn4zDFvZSknnXb6yvq2+g0WvLCnRSTUg15CSfmZ8QU7Sx8u16el6+gZZGsqwzLx9 KBuV56AoSpIT5n2KiFFvtcyNsQ0H7P+zbtMBiKBTSLwGLFs6nQFNeZMSFa8xEQoIVjYp UK9w== X-Gm-Message-State: ABy/qLZ/KZFmtrOpJFDRx1N46Dv+2u/+jmWeKNO36SPFb/yT4hp46rP+ o418uU3LefU/Z91peI7kdelip/wgolOnqI4hZ12zIJdXGLBKYXJeZzrf7ka2FwGziJOXJD9+J8V ZAv/Icyf3FDLRU5OSPZzp8QdHSZqC X-Received: by 2002:adf:e490:0:b0:314:475:bc6b with SMTP id i16-20020adfe490000000b003140475bc6bmr743444wrm.18.1688068439954; Thu, 29 Jun 2023 12:53:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlH9LIqKwHX2Ms57Crh1R/cDZlGd6T1A6BEFfe1Ry+sF/LaGSThXC8FBQFVdpXj01yMvR2/SRg== X-Received: by 2002:adf:e490:0:b0:314:475:bc6b with SMTP id i16-20020adfe490000000b003140475bc6bmr743431wrm.18.1688068439628; Thu, 29 Jun 2023 12:53:59 -0700 (PDT) Date: Thu, 29 Jun 2023 15:53:55 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: virtio-comment@lists.oasis-open.org, cohuck@redhat.com, david.edmondson@oracle.com, virtio-dev@lists.oasis-open.org, sburla@marvell.com, jasowang@redhat.com, yishaih@nvidia.com, maorg@nvidia.com, shahafs@nvidia.com Message-ID: <20230629155022-mutt-send-email-mst@kernel.org> References: <20230627211050.1527507-1-parav@nvidia.com> <20230627211050.1527507-5-parav@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20230627211050.1527507-5-parav@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [PATCH v7 4/4] transport-pci: Introduce group legacy group member config region access On Wed, Jun 28, 2023 at 12:10:50AM +0300, Parav Pandit wrote: > This patch links how in a PCI transport a group owner can access group > member (PCI VFs) legacy registers using a legacy registers access > commands using administration virtqueue infrastructure. > > Additionally it extend the PCI notification capability through which a > PCI VF device indicates to the driver which PCI BAR region to be used > for driver notifications. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/167 > Signed-off-by: Parav Pandit > --- > changelog: > v6->v7: > - addressed comments from Michael > - removed driver normative about I/O BAR emulation as it does not > make much sense for the spec > - removed references to administration virtqueue > - rewrote driver legacy region access without guest and hypervisor > wording > - added normative for notification region > - added normative for PCI IDs for device which support legacy commands > v5->v6: > - aligned pci capability to 4B as required by PCI spec > - added text for the PCI capability for the group member device > v4->v5: > - split pci transport and generic command section to new patch > - removed multiple references to the VF > - written the description of the command as generic with member > and group device terminology > - reflected many section names to remove VF > v3->v4: > - moved noted to the conformance section details in next patch > - removed queue notify address query AQ command on Michael's suggestion, > though it is fine. Instead replaced with extending virtio_pci_notify_cap > to indicate that legacy queue notifications can be done on the > notification location. > - fixed spelling errors. > - replaced administrative virtqueue to administration virtqueue > - added queue notification capability register to indicate legacy q > notification supported > v2->v3: > - adddressed Jason and Michael's comment to split single register > access command to common config and device specific commands. > - dropped the suggetion to introduce enable/disable command as > admin command cap bit already covers it. > v1->v2: > - addressed comments from Michael > - added theory of operation > - grammar corrections > - removed group fields description from individual commands as > it is already present in generic section > - added endianness normative for legacy device registers region > - renamed the file to drop vf and add legacy prefix > > - added overview in commit log > - renamed subsection to reflect command > --- > conformance.tex | 1 + > transport-pci-legacy-regs.tex | 43 +++++++++++++++++++++++++++++++++++ > transport-pci.tex | 2 ++ > 3 files changed, 46 insertions(+) > create mode 100644 transport-pci-legacy-regs.tex > > diff --git a/conformance.tex b/conformance.tex > index dc00e84..b3f2c92 100644 > --- a/conformance.tex > +++ b/conformance.tex > @@ -267,6 +267,7 @@ \section{Conformance Targets}\label{sec:Conformance / Conformance Targets} > \item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / Legacy Interfaces: A Note on PCI Device Layout} > \item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Device Initialization / Virtio Device Configuration Layout Detection / Legacy Interface: A Note on Device Layout Detection} > \item Section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device Operation / Device Initialization / Virtqueue Configuration / Legacy Interface: A Note on Virtqueue Configuration} > +\item Section \ref{devicenormative:Virtio Transport Options / Virtio Over PCI Bus / Legacy Interface: Group Member Device Configuration Region Access} > \item Section \ref{sec:Virtio Transport Options / Virtio Over MMIO / Legacy interface} > \item Section \ref{sec:Virtio Transport Options / Virtio over channel I/O / Device Initialization / Setting the Virtio Revision / Legacy Interfaces: A Note on Setting the Virtio Revision} > \item Section \ref{sec:Virtio Transport Options / Virtio over channel I/O / Device Initialization / Configuring a Virtqueue / Legacy Interface: A Note on Configuring a Virtqueue} > diff --git a/transport-pci-legacy-regs.tex b/transport-pci-legacy-regs.tex > new file mode 100644 > index 0000000..9559768 > --- /dev/null > +++ b/transport-pci-legacy-regs.tex > @@ -0,0 +1,43 @@ > +\subsection{Legacy Interface: Group member device Configuration Region Access}\label{sec:Virtio Transport Options / Virtio Over PCI Bus / Legacy Interface: Group Member Device Configuration Region Access} > + > +The PCI owner device or the member device or both supports driver notifications using > +a notification region defined in the \field{struct virtio_pci_notify_region}. > + > +In \field{struct virtio_virtio_admin_cmd_legacy_notify_query_entry}, > +\field{region} is defined as following: > + > +\begin{lstlisting} > +struct virtio_pci_notify_region { > + u8 owner; /* When set to 1, notification region of the owner device */ > + u8 bar; /* BAR of the member or owner device */ > + u8 padding[2]; > + le32 offset; /* Offset within bar. */ > +}; > +\end{lstlisting} Is this just a legacy thing or somehow generic? If the former please stick _legacy_ in the struct name. > + > +The group owner device hardwire VF BAR0 in the SR-IOV Extended capability. > + > +The group member device does not use PCI BAR0 in various PCI capabilities. what does this mean? what various capabilities? VFs don't have PCI BAR0 at all ... > + > +\devicenormative{\subsubsection}{Legacy Interface: Group Member Device Legacy Configuration Region Access}{Virtio Transport Options / Virtio Over PCI Bus / Legacy Interface: Group Member Device Configuration Region Access} > + > +When a PCI SR-IOV group owner device supports > +VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_READ, > +VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_WRITE, VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_READ, > +VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_WRITE commands, the group owner device MUST > +hardwire VF BAR0 in the SR-IOV Extended capability and the group member device > +MUST NOT use BAR0 in any of the Virtio Structure PCI Capabilities. > + > +The group member driver SHOULD use the notification region supplied by the group > +owner driver. > + > +The group owner device or the group member device or both MAY support driver > +notifications region. why is this text here as opposed to the other file? But really I think for now it's easier to just have everything in admin-cmds-legacy-interface.tex > + > +For the SR-IOV group type, the owner device supporting > +VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_READ, > +VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_WRITE, VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_READ, > +VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_WRITE and VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_QUERY > +commands and its member device SHOULD follow the rules for the PCI Device ID, > +Revision ID and Subsystem Device ID of the non-transitional devices documented in > +section \ref{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Discovery}. > diff --git a/transport-pci.tex b/transport-pci.tex > index a5c6719..72c78f6 100644 > --- a/transport-pci.tex > +++ b/transport-pci.tex > @@ -1212,3 +1212,5 @@ \subsubsection{Driver Handling Interrupts}\label{sec:Virtio Transport Options / > re-examine the configuration space to see what changed. > \end{itemize} > \end{itemize} > + > +\input{transport-pci-legacy-regs.tex} > -- > 2.26.2 --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org