[virtio-dev] Re: [PATCH v7 3/4] admin: Add group member legacy register access commands

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Jun 29, 2023 at 09:50:45PM +0000, Parav Pandit wrote:
> 
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Thursday, June 29, 2023 5:46 PM
> 
> > > > Or preferably I would just include that tex right here to avoid the
> > > > need to jump back and forth.
> > > >
> > > We have vq notify config data as generic and transport specific
> > > listing,
> > 
> > But note how that is included directly in multiple places - not a link. In the
> > resulting PDF it appears inline.
> 
> For notify data structure is not defined, so its little simpler.
> Here for AQ command structure is defined in the generic section as just bytes.
> 
> I have mixed feelings; I think definition in transport and link in generic section is fine.
> Are you ok with that?

I am yet to focus on wording, can't tell you for sure.  My gut feeling
is that keeping everything in one place would be more readable, will
help us converge more quickly, and the next user of admin commands is
expected to be SIOV which would need the same structure anyway (it's
also PCI).

Also look at virtio_pci_notify_cap and check whether any
normative statements there should apply here. Alignment I guess?

> > 
> > > So will improve this part of text with link.
> > 
> > anyway, that's not part of ABI.


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org