From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCBFCEB64D9 for ; Thu, 6 Jul 2023 06:10:17 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 4253B6008D for ; Thu, 6 Jul 2023 06:10:17 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 1480D9867F9 for ; Thu, 6 Jul 2023 06:10:17 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id DC6A5986724; Thu, 6 Jul 2023 06:10:16 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id C47D6986726 for ; Thu, 6 Jul 2023 06:10:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: dqXdu5A5PZquxBcwgv7mQw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688623814; x=1691215814; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=akuF4yvADvDP2yHBTfV+EMwk9mnnynho/bRaZfcDiDc=; b=ioXgtYrRY5RPaA1algmxWah9pKAvOO+tjgVXTmXB+H0KEIbdHeHmfPwJHeqDHsOjNQ ARpEtZE18oCArKNlE8iXVaSWHEevRyZoDTzv9hcF3TQgtMFRlcgZPCKJ3wNw/rccOkAk I/SkIDdIaxVBZLb3wERLDD7tIqmWAOrObdI1FPCofrN1K15NVKEkA2A0wxITH2xXGcnG a5lEZVUoEIWihvTVAWNHEwcFJkBJqrmX+v5KuiAEvq4Bwexu75c30mc4tP3w1MTctDIS WXbVTpyBIjruwHt9vHQAvabtMUjMzz1fmN/kWEwueokHeFx/knxN9Z1tPD2e/qze/Ldp t5vw== X-Gm-Message-State: ABy/qLY1x9qxKUA1U8SPjSydBUATWBIwOU0QfGBTCFAkHWvmUuCWWZhc RbmJpuCEYWPCxZIGGeH5ZCa6IU27lc0jaZF2YievQnmBBFdqyR6WbNPu6qdvA4MrUPVmpXlNoqz VNKlJoZfegmLkY+8kYUuZNJ+Anqnj X-Received: by 2002:a05:6000:545:b0:314:3344:72f6 with SMTP id b5-20020a056000054500b00314334472f6mr705587wrf.32.1688623813946; Wed, 05 Jul 2023 23:10:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlFbjaICPNH9Pg8ogZHrLrtARuLztQfY2locQUdYaVyhrqo+DQD+wNVOEdS5FikJ7SSUF3nGiQ== X-Received: by 2002:a05:6000:545:b0:314:3344:72f6 with SMTP id b5-20020a056000054500b00314334472f6mr705576wrf.32.1688623813682; Wed, 05 Jul 2023 23:10:13 -0700 (PDT) Date: Thu, 6 Jul 2023 02:10:10 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: "virtio-comment@lists.oasis-open.org" , "cohuck@redhat.com" , "david.edmondson@oracle.com" , "virtio-dev@lists.oasis-open.org" , "sburla@marvell.com" , "jasowang@redhat.com" , Yishai Hadas , Maor Gottlieb , Shahaf Shuler Message-ID: <20230706020803-mutt-send-email-mst@kernel.org> References: <20230704233724.22394-1-parav@nvidia.com> <20230705070758-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [virtio-comment] [PATCH v9 0/4] admin: Access legacy registers using admin commands On Thu, Jul 06, 2023 at 04:20:03AM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Wednesday, July 5, 2023 7:09 AM > > > OK I sent a bunch of comments. Pls try to address, unfortunately I didn't go in > > depth over the last patch, but I feel it should be squashed into the generic > > legacy command sections avoiding need for indirection, so rewriting it now > > wouldn't be efficient. > > I address all your comments and of Cornelia. > PCI part I still prefer to be separate so kept it. > > Thanks a lot. I clarified some questions you asked about. Maybe v11 is justified in view of my answers. Let me know before I review again. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org