From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FA7FEB64D9 for ; Thu, 6 Jul 2023 16:51:08 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id A382542A66 for ; Thu, 6 Jul 2023 16:51:07 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 8AF9098672C for ; Thu, 6 Jul 2023 16:51:07 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 72E28986728; Thu, 6 Jul 2023 16:51:07 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 5EE1D98672A for ; Thu, 6 Jul 2023 16:51:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: NQ2y0h3kONGgXMkOeeix8w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688662264; x=1691254264; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QpzNEdxIKJZ+BQlN6Ca3peKTKi8NtfhLIxeAN1kxlko=; b=YdqiLk2tRRREtB0j2Y/aH0zxIwdplY9xIITxMkisg7uuJZ4oVN0rPbZ/wKUSOIAKcc NbhkoMB7Lbd4KXpdt8jgm5MnROFXLTQdLg7t0dH6mPaAnBQj/GILFHO2qTLf5JoVRtsV 0tRPttLkATGzoLevCtIs+sMNp9dwEh3x0vmbghXSHT2euecEKDPDnwlE659c4YKjd7+O oQtbxtnP59zQpHKN12lznerKLAF6usbrzXVBEtHjb/B6O6UG6qjFd+oLPEKwOyjfEnJK Jq7aW3IJH7R6sB7Sgk8S2Y1N/hGZ+LuexUQw4fsBY5IMuSESI21ZqSfMsob11EHsRe6h LmGA== X-Gm-Message-State: ABy/qLZgovMJ7PUWZrZJLebUZzAgkgxre50acBn8iaGI/vQYlAXUcaEz jl0bvuf0W9iK0PVBbaGUTL0mV1uDapwRwgF8BFU9ZMbBn9mglQpsgoNDdfNaIk2H7UOqb+ZQEE6 JO3QlDfslgcQYbTzfr53XgOsJlSl5 X-Received: by 2002:a05:600c:1d04:b0:3fb:b075:8239 with SMTP id l4-20020a05600c1d0400b003fbb0758239mr5487548wms.4.1688662264305; Thu, 06 Jul 2023 09:51:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlE/ea7m5TWVG0LLBFRUY6jPQ9MDI/bBYQ5plHSWiKXi3BN9+VIFvfw9g9xWA6ZGz2BLzUrepw== X-Received: by 2002:a05:600c:1d04:b0:3fb:b075:8239 with SMTP id l4-20020a05600c1d0400b003fbb0758239mr5487533wms.4.1688662263908; Thu, 06 Jul 2023 09:51:03 -0700 (PDT) Date: Thu, 6 Jul 2023 12:50:59 -0400 From: "Michael S. Tsirkin" To: Parav Pandit Cc: Cornelia Huck , "virtio-comment@lists.oasis-open.org" , "david.edmondson@oracle.com" , "virtio-dev@lists.oasis-open.org" , "sburla@marvell.com" , "jasowang@redhat.com" , Yishai Hadas , Maor Gottlieb , Shahaf Shuler Message-ID: <20230706125001-mutt-send-email-mst@kernel.org> References: <20230706041714.65600-1-parav@nvidia.com> <20230706041714.65600-5-parav@nvidia.com> <87r0pluhqy.fsf@redhat.com> <20230706123220-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] Re: [PATCH v10 4/4] transport-pci: Introduce group legacy group member config region access On Thu, Jul 06, 2023 at 04:45:50PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Thursday, July 6, 2023 12:39 PM > > > > > +The group owner device or the group member device or both MAY > > > > +support driver notifications region. > > > > > > Make this "a driver notification region"? > > > > I think in fact for conformance we can just refer to supporting the command. > > The command can return an array of structures, each referring to the memory > > of the owner device or the member device. > > > Array and referring to owner/member is already present in this patch. I don't see a statement that devices MAY support VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_QUERY with entries returning just owner, just member, or both. > Do you suggest to drop above statement? > > > > > > + > > > > +For the SR-IOV group type, the owner device supporting > > > > +VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_READ, > > > > +VIRTIO_ADMIN_CMD_LEGACY_COMMON_CFG_WRITE, > > > > +VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_READ, > > > > +VIRTIO_ADMIN_CMD_LEGACY_DEV_CFG_WRITE and > > > > +VIRTIO_ADMIN_CMD_LEGACY_NOTIFY_QUERY > > > > +commands and its member device SHOULD follow the rules for the PCI > > > > +Device ID, > > > > what does "its" mean here? Of the group? > Yes, will change to the member device of the group. > > > Members of the SR-IOV group type are VFs. They can not follow the rules for > > the Device ID: the spec says: > > This field in all VFs returns FFFFh when read. > > > > Even if you somehow refer to the software it's extraneous anyway since the > > spec proceeds: VI software should return the Vendor ID value from the > > associated PF as the Vendor ID value for the VF. > > > > We'll need a separate statement for Device ID. > > > Will split the line for Device ID. > > > > > +Revision ID and Subsystem Device ID of the non-transitional devices > > > > +documented in section \ref{sec:Virtio Transport Options / Virtio Over PCI > > Bus / PCI Device Discovery}. --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org