[virtio-dev] RE: [PATCH v11 3/3] admin: Add group member legacy register access commands

Parav Pandit
2023-07-07T03:54:54Z

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Thursday, July 6, 2023 6:36 PM

[..]

> I notice you decided to silently ignore my suggestion to document how are
> notifications performed. Repeating myself like this is despiriting for me.
I am sorry if it appeared that way,
But no, I didn’t silently ignored.

I added the description as best I could find it, but you commented about it being messy with mixing up the terminology.
I rewrote it in v12, it looks better now. Please check.

> Pls re-add especially since you already document it for the cfg_Write access
> method anyway.
>
Added without citation to hypervisor etc.

>
> also in a conformance section, document the effect of notification being the
> same as notification through legacy interface.

PCI specific things were copied from the current spec reference in the notification capability section.
All the changes you suggested are done.
Captured in the change log of v12.

Thanks a lot.
Since many parts are rewritten as you suggested in the thread,
I prefer to add your Signed-off to in v13 if we need roll it or when it is merged, please apply if you find it appropriate.
It is at least important to me to add it yours Sign-off.