[virtio-dev] RE: [PATCH v15] admin: Add group member legacy register access commands

Parav Pandit
2023-07-13T13:44:08Z

Hi Michael, Cornelia,

> From: Parav Pandit <parav@nvidia.com>
> Sent: Tuesday, July 11, 2023 11:02 AM
> To: virtio-comment@lists.oasis-open.org; mst@redhat.com;
> cohuck@redhat.com; david.edmondson@oracle.com

[..]

> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/167
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> changelog:
> v14->v15:
> - addressed below editorial comments from Michael
> - replaced 'is' with 'are' for command description
> - simplified wording around ignore and skip to just use ignore
> - to -> in preference to
> - small rewording for flags description
> v13->v14:
> - addressed below comments from Michael
> - reworded BAR 1 to 5 text as_is suggested by Michael
> - added text for skipping invalid entries
> - replaced 'contains' with 'contain'
> - removed 'related to the base address associated'
> - addressed comments from Cornelia
> - added article the at many places
> - replaced does not to do not
> - reworded the driver normative for flags parsing
> v12->v13:
> - added article
> - add hyphen between little and endian
> - mentioned vq index depth of 16-bit
> - rewrote alternative approach line
> - mention vq index, length and endianness in mmio description
> - fixed padding bytes size from 7 to 6 bytes
> - rewrote bar field description
> - offset alignment text added
> - added text to ignore reserved notification entries
> - device and driver conformance lines added for notification info command
> fields
> - dropped group member prefix to the driver
> - reworded text for flags requirements
> - reworded to say all driver notifications in conformance
> - itemize conformance section under command to ease reading
> v11->v12:
> - added missing article the at few places
> - rewrote group_member_id statements like other existing
> commands which is cleaner and shorter
> - added length and alignment lines to multiple commands
> - rewrote fast path to separate dedicated mechanism
> - rewrote example and description para for legacy notification command
> - made separate paragraph for the notify info command
> - dropped citation to virtio pci capabilities for member device
> - notification region changed to notification address throughout
> - added description to all the fields of the info struct
> - avoided union in spirit of keeping all for pci
> - used single listing
> - moved description to end which was in between two structs
> - added 4 entry and preference description
> - added conformance line for notification via mmio works same way as
> admin command
> v10->v11:
> - replaced tab with white spaces in read structure
> - included pci fields along side other generic fields to avoid
> indirection
> - merged pci conformance section
> - avoid using definite in starting introduction
> - replace 'all of the' with 'any of the'
> - changed drivers notification normative to indicate use of
> NOTIFY_INFO command
> - renamed NOTIFY_QUERY to NOTIFY_INFO name
> - merged 4th patch with 3rd
> - added normative line for notify_info command
> - reworded notification region command description to be more verbose
> - merged flags and owner field to indicate end of list

Now that last few iterations handled all the suggested edits,
Can you please start the voting for it?