From: "Michael S. Tsirkin" <mst@redhat.com>
To: Roman Kiryanov <rkir@google.com>
Cc: virtio-dev@lists.linux.dev, JP Cottin <jpcottin@google.com>
Subject: Re: VIRTIO_VSOCK_OP_REQUEST with the same src_port from a guest
Date: Mon, 1 Jul 2024 15:40:36 -0400 [thread overview]
Message-ID: <20240701153918-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAOGAQepE5G+yR0FQMFW8oZ24p0DVKZgmkDJsB09hbxF+P7KvCQ@mail.gmail.com>
On Mon, Jul 01, 2024 at 12:16:15PM -0700, Roman Kiryanov wrote:
> Hi Michael, thank you for looking.
>
> as I mentioned, I have never seen this happening.
>
> But this code path (on the device side) exists (e.g. insertion of
> <dst_port, src_port> to a
> hash table says that the key already exists) even if it is never taken
> and I would be nice
> if the virtio-spec mentioned explicitly what to do there.
>
> Regards,
> Roman.
Can Linux driver ever trigger this? Some other driver?
If this is something that drivers don't actually ever
trigger, why does it matter how exactly the device
behaves?
--
MST
next prev parent reply other threads:[~2024-07-01 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 17:35 VIRTIO_VSOCK_OP_REQUEST with the same src_port from a guest Roman Kiryanov
2024-07-01 18:44 ` Michael S. Tsirkin
2024-07-01 19:16 ` Roman Kiryanov
2024-07-01 19:40 ` Michael S. Tsirkin [this message]
2024-07-01 19:55 ` Roman Kiryanov
2024-07-01 21:01 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701153918-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jpcottin@google.com \
--cc=rkir@google.com \
--cc=virtio-dev@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox