From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BECBD42070 for ; Fri, 26 Jul 2024 13:04:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721999092; cv=none; b=sdk3aSt3CJqojdW0PtybvfLfZAuaImAokMEoM1ct7eKuOlZ4gOgR/WmQNeiL9gKq/rHzWhZq+JRlwC68h3KsqJ0wxa5KV+C/0k2qv0vKTmcFGZurB8OZZo5bWfEcwcQ9HLkHTzNgVbBCmG4vnK08IhwFL07xGR3xuotJVfOQBpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721999092; c=relaxed/simple; bh=uO12G0ckq47fIdqtlyWIWsBBD7gHquBqgoUXT4gDyT0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=NfKmytUVW9tX7zEsZvtAjO1oz/Tyg4pJSx4o5FM+qUfPHMb7vouhnvteLuIvjVuf8nNQWtVFDnpcKFfTBzzFGZv7FDRyJSTybIy2NrtymODqVh32+HI86Hpiv7sVGFM7TqvAfguusbbeoUrJoMGb6zt26cBdVtcp3TEBuCfM6+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RyaflvMl; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RyaflvMl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721999089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=B3g6QURrGZPYRxDC3Hx/i8519mXf108ro6Hrgt5KPqY=; b=RyaflvMlkp9q9U9vkTVYZHyYhNQ9E70HW9g3yCMmoNczBVFydqCP6jXiJ93/N5mLUT7pRu css/8kzPhXPywve/aXIwM8hjnloj7CeYNA5VgpX9A8Kx0aDF404B6ogOw1tPMH25xXFnZu ML/rrX7TJS+bLXiZXGUilAVYgSjkKAA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-223-20wQfOMuMPO6QpMgn7tiWQ-1; Fri, 26 Jul 2024 09:04:48 -0400 X-MC-Unique: 20wQfOMuMPO6QpMgn7tiWQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3679ab94cdbso1162667f8f.3 for ; Fri, 26 Jul 2024 06:04:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721999087; x=1722603887; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B3g6QURrGZPYRxDC3Hx/i8519mXf108ro6Hrgt5KPqY=; b=pDGf6adE5ir4sNb1jLwTuMvlxv0tQtUVrUrDtwVujpdNt7fXRepyWe1hdOj7z1UAMq Ok+bJPM2rAIzeSL6sDVhawnC0AOJESzNdB9yC1PlsOO9WCifi7jSvtsMZhvoK3vqXvsz Feh+bViDdnfMmN1VueXNiJoqE5NikSn9HwnwB1O9BnSo/4C4x14HBAfZMMU7Ci6xqq0k R0QgbCLXyqCXwJkDrHsQx8QQ/eZrkpkb4wb2gUAxyFPZEfaTRfz4dIc/fqGIhymfKbLq b8oIhj/MGHhz2g/HTwp+T7M23t70eVxeSefIJMHD3SyfiJZraAZEUN/nmc9QCFAUbw5O goyg== X-Forwarded-Encrypted: i=1; AJvYcCVeXiStqTtDcqRwhg0dhX0nepn6+E0p4MEeEJ0Hpmrd44FXozgAqwjd/35PZwc7fnUIf9eu6Wd2lnmGLac81FtMB0UnBwWT0v+OSQ== X-Gm-Message-State: AOJu0YwNq1PQROH8Pv0txwFwCNfPg6c3WN7xJL+WIY5Hp1p6qkTPiVR/ ApHp9No9onsd6RWmFdQvVhZATGHRMrxKJCPCjV7xt2eyLSQR5SjN8XIOv80X/gMk9hcvxHJF6Sj 2mNSMYynaJOvfnfKx+CgNnOQ+M1QF2hHn+Cm2Y5MKT5c7IeOJWVCaVtiJhS0= X-Received: by 2002:adf:f40e:0:b0:368:4ed7:2acc with SMTP id ffacd0b85a97d-36b3638148cmr3751296f8f.5.1721999087366; Fri, 26 Jul 2024 06:04:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2baiiVUKUBh/QT4ya/E9LOG3bE0mPK5t7EPOeVJPpQaN0mCePZ4SEB2ju0LD0SShA7ME5CA== X-Received: by 2002:adf:f40e:0:b0:368:4ed7:2acc with SMTP id ffacd0b85a97d-36b3638148cmr3751249f8f.5.1721999086564; Fri, 26 Jul 2024 06:04:46 -0700 (PDT) Received: from redhat.com ([2a02:14f:1f7:28ce:f21a:7e1e:6a9:f708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b36801828sm5090963f8f.65.2024.07.26.06.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 06:04:46 -0700 (PDT) Date: Fri, 26 Jul 2024 09:04:38 -0400 From: "Michael S. Tsirkin" To: David Woodhouse Cc: Richard Cochran , Peter Hilber , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, "Ridoux, Julien" , virtio-dev@lists.linux.dev, "Luu, Ryan" , "Chashper, David" , "Mohamed Abuelfotoh, Hazem" , "Christopher S . Hall" , Jason Wang , John Stultz , netdev@vger.kernel.org, Stephen Boyd , Thomas Gleixner , Xuan Zhuo , Marc Zyngier , Mark Rutland , Daniel Lezcano , Alessandro Zummo , Alexandre Belloni , qemu-devel , Simon Horman Subject: Re: [PATCH] ptp: Add vDSO-style vmclock support Message-ID: <20240726090326-mutt-send-email-mst@kernel.org> References: <20240725163843-mutt-send-email-mst@kernel.org> <20240725170328-mutt-send-email-mst@kernel.org> <20240725174327-mutt-send-email-mst@kernel.org> <9261e393083bcd151a017a5af3345a1364b3e0f3.camel@infradead.org> <20240726015613-mutt-send-email-mst@kernel.org> <2e427b102d8fd899a9a3db2ec17a628beb24bc01.camel@infradead.org> <20240726084836-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: virtio-dev@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 26, 2024 at 02:00:25PM +0100, David Woodhouse wrote: > On Fri, 2024-07-26 at 08:52 -0400, Michael S. Tsirkin wrote: > > On Fri, Jul 26, 2024 at 09:35:51AM +0100, David Woodhouse wrote: > > > But for this use case, we only need a memory region that the hypervisor > > > can update. We don't need any of that complexity of gratuitously > > > interrupting all the vCPUs just to ensure that none of them can be > > > running userspace while one of them does an update for itself, > > > potentially translating from one ABI to another. The hypervisor can > > > just update the user-visible memory in place. > > > > Looks like then your userspace is hypervisor specific, and that's a > > problem because it's a one way street - there is no way for hypervisor > > to know what does userspace need, so no way for hypervisor to know which > > information to provide. No real way to fix bugs. > > It's not hypervisor specific, but you're right that as it stands there > is no negotiation of what userspace wants. So the hypervisor provides > what it feels it can provide without significant overhead (which may or > may not include the precise timekeeping, as discussed, but should > always include the disruption signal which is the most important > thing). > > The guest *does* know what the hypervisor provides. And when we get to > do this in virtio, we get all the goodness of negotiation as well. The > existence of the simple ACPI model doesn't hurt that at all. Maybe it doesn't, at that. E.g. virtio does a copy, acpi doesn't? I'll ponder compatibility over the weekend. -- MST