[virtio-dev] Re: [PATCH 08/11] transport-pci: Introduce virtio extended capability

Parav Pandit
2023-04-10T16:22:08Z

On 4/4/2023 10:37 AM, Michael S. Tsirkin wrote:
> On Tue, Apr 04, 2023 at 03:19:53PM +0200, Cornelia Huck wrote:
>>>>> What does it "Co-developed-by" mean exactly that Signed-off-by
>>>>> does not?
>>>>
>>>> AIUI, "Co-developed-by:" is more akin to a second "Author:", i.e. to
>>>> give attribution. (Linux kernel rules actually state that any
>>>> "Co-developed-by:" must be followed by a "Signed-off-by:" for that
>>>> author, but we don't really do DCO here, the S-o-b is more of a
>>>> convention.)
>>>
>>>
>>> Actually, we might want to generally, to signify agreement to the IPR.
>>> How about adding this to our rules? But in this case Satananda Burla is
>>> a TC member so yes, no problem.
>>
>> Adding a s-o-b requirement is not a bad idea... do you want to propose
>> an update?
>
> OK how about the following:
>
> ---------------
> The process for forwarding comments from others:
>
> Generally, subscribing to the virtio comments mailing list
> requires agreement to the OASIS feedback license, at
> https://www.oasis-open.org/who/ipr/feedback_license.pdf
>
It is not straight forward for non virtio tc member to realize above
obligation.
It is worth to document it in the section [1].

[1]
https://www.oasis-open.org/committees/tc_home.php?wg_abbrev=virtio#feedback

Something like,

From:
If you're interested in following ongoing development and can't join the
committee, I recommend you subscribe to the virtio-comment and
virtio-dev lists.

To:
If you're interested in following ongoing development and can't join the
committee, I recommend you subscribe to the virtio-comment and
virtio-dev lists. Your contribution to above mailing lists is licensed
under the OASIS feedback license agreement describe at [1].

> When forwarding (in modified or unmodified form) comments from others, please
> make sure the commenter has read and agreed to the
> feedback license. If this is the case, please include the following:
>
> License-consent: commenter's name <commenter's email>
>
> where commenter's name <commenter's email> is a valid
> name-addr as specified in RFC 5322, see
> https://datatracker.ietf.org/doc/html/rfc5322#section-3.4
>
> If the comment is on behalf of an organization, please use the
> organization's email address.
>
>
> If forwarding a comment from a TC member, please instead get consent to
> the full Virtio TC IPR, and then, as before, include
>
> License-consent: commenter's name <commenter's email>
>
License-consent tag do not capture the contribution by other virtio tc
member(s) in the generated comment.

Signed-off-by captures it.

So both tags are needed depending on comment contribution type.

Rest above change looks good to me.

> If you are reusing a comment that has already been posted to the
> TC mailing list, the above tags are not required.
>
> ---------------
>
> We could reuse Signed-off-by though I am a bit concerned whether
> people will assume it's a DCO thing which everyone copies.
> Thoughts?