From: Haixu Cui <quic_haixcui@quicinc.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: <harald.mommer@oss.qualcomm.com>, <quic_msavaliy@quicinc.com>,
<broonie@kernel.org>, <virtio-dev@lists.linux.dev>,
<viresh.kumar@linaro.org>, <linux-spi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <hdanton@sina.com>,
<qiang4.zhang@linux.intel.com>, <alex.bennee@linaro.org>,
<quic_ztu@quicinc.com>
Subject: Re: [PATCH v4 2/3] virtio-spi: Add virtio-spi.h
Date: Mon, 25 Aug 2025 16:35:58 +0800 [thread overview]
Message-ID: <4ae827e8-646a-4070-b06e-23bcd261ffcd@quicinc.com> (raw)
In-Reply-To: <aKXaI0SAAMaHMZM9@smile.fi.intel.com>
On 8/20/2025 10:22 PM, Andy Shevchenko wrote:
> On Wed, Aug 20, 2025 at 04:49:43PM +0800, Haixu Cui wrote:
>> Add virtio-spi.h header for virtio SPI.
>
> ...
>
>> +/**
>
> This is kernel-doc comment...
>
>> + * struct virtio_spi_config - All config fields are read-only for the
>> + * Virtio SPI driver
>
>> + */
>
> ...
>
>> +/*
>> + * @chip_select_id: chipselect index the SPI transfer used.
>> + *
>
> But this one (besides having tons of unneeded blank lines) is not. Why is this
> inconsistency?
>
>> + */
>
Thank you for pointing out the inconsistency. I will update the comment
to follow the kernel-doc format and remove the unnecessary blank lines.
This change will be reflected in the next patch version.
> ...
>
>> +struct spi_transfer_result {
>> +#define VIRTIO_SPI_TRANS_OK 0
>> +#define VIRTIO_SPI_PARAM_ERR 1
>> +#define VIRTIO_SPI_TRANS_ERR 2
>> + __u8 result;
>> +};
>
> And this data type has no doc at all...
>
Okay, will add definition for spi_tranafer_result.
next prev parent reply other threads:[~2025-08-25 8:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 8:49 [PATCH v4 0/3] Virtio SPI Linux driver Haixu Cui
2025-08-20 8:49 ` [PATCH v4 1/3] virtio: Add ID for virtio SPI Haixu Cui
2025-08-20 8:49 ` [PATCH v4 2/3] virtio-spi: Add virtio-spi.h Haixu Cui
2025-08-21 8:42 ` Michael S. Tsirkin
2025-08-25 9:12 ` Haixu Cui
2025-08-28 10:19 ` Michael S. Tsirkin
2025-08-21 8:45 ` Michael S. Tsirkin
2025-08-25 9:19 ` Haixu Cui
2025-08-28 10:34 ` Michael S. Tsirkin
2025-09-03 6:55 ` Haixu Cui
2025-09-03 7:00 ` Haixu Cui
[not found] ` <aKXaI0SAAMaHMZM9@smile.fi.intel.com>
2025-08-25 8:35 ` Haixu Cui [this message]
2025-08-20 8:49 ` [PATCH v4 3/3] SPI: Add virtio SPI driver Haixu Cui
2025-08-21 2:22 ` kernel test robot
[not found] ` <aKXePVShWzXGi8yP@smile.fi.intel.com>
2025-08-25 9:01 ` Haixu Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ae827e8-646a-4070-b06e-23bcd261ffcd@quicinc.com \
--to=quic_haixcui@quicinc.com \
--cc=alex.bennee@linaro.org \
--cc=andriy.shevchenko@intel.com \
--cc=broonie@kernel.org \
--cc=harald.mommer@oss.qualcomm.com \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=qiang4.zhang@linux.intel.com \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_ztu@quicinc.com \
--cc=viresh.kumar@linaro.org \
--cc=virtio-dev@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox