[virtio-dev] Re: [PATCH 2/2] transport-pci: Improve queue msix vector register desc

Michael S. Tsirkin
2023-04-19T07:09:09Z

On Wed, Apr 19, 2023 at 03:08:30AM -0400, Michael S. Tsirkin wrote:
> On Tue, Apr 11, 2023 at 10:42:20PM +0300, Parav Pandit wrote:
> > queue_msix_vector register is for receiving interrupts from the device
> > for the virtqueue.
> >
> > "for MSI-X" is confusing term.
> >
> > Also it is the register that driver "writes" to, similar to
> > many other registers such as queue_desc, queue_driver etc.
> >
> > Hence, replace the verb from use to write.
> >
> > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> > ---
> > changelog:
> > v0->v1:
> > - added 'here'
> > - dropped 'receiving'
> > ---
> > transport-pci.tex | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/transport-pci.tex b/transport-pci.tex
> > index cb9fadd..00669b5 100644
> > --- a/transport-pci.tex
> > +++ b/transport-pci.tex
> > @@ -367,7 +367,7 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
> > A 0 means the queue is unavailable.
> >
> > \item[\field{queue_msix_vector}]
> > - The driver uses this to specify the queue vector for MSI-X.
> > + The driver writes an MSI-X vector number here for virtqueue interrupts.
>
> Here it's *the* specific queue not just some queue. And in fact
> we call them virtqueue notifications, not interrupts elsewhere.
> So how about:
>
> Used by the driver to set the MSI-X vector number for the virtqueue notifications.

or even "the virtqueue notification interrupts".

>
> > \item[\field{queue_enable}]
> > The driver uses this to selectively prevent the device from executing requests from this virtqueue.
> > --
> > 2.26.2