From: Wei Wang <wei.w.wang@intel.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
mst@redhat.com, quintela@redhat.com, peterx@redhat.com,
pbonzini@redhat.com, liliang.opensource@gmail.com,
nilal@redhat.com, riel@redhat.com
Subject: [virtio-dev] Re: [PATCH v11 1/7] bitmap: fix bitmap_count_one
Date: Fri, 14 Dec 2018 14:37:34 +0800 [thread overview]
Message-ID: <5C134FAE.9030300@intel.com> (raw)
In-Reply-To: <20181213142800.GO2313@work-vm>
On 12/13/2018 10:28 PM, Dr. David Alan Gilbert wrote:
> * Wei Wang (wei.w.wang@intel.com) wrote:
>> BITMAP_LAST_WORD_MASK(nbits) returns 0xffffffff when "nbits=0", which
>> makes bitmap_count_one fail to handle the "nbits=0" case. It appears to be
>> preferred to remain BITMAP_LAST_WORD_MASK identical to the kernel
>> implementation that it is ported from.
>>
>> So this patch fixes bitmap_count_one to handle the nbits=0 case.
> OK; it's a little odd that it's only bitmap_count_one that's being fixed
> for this case; but OK.
>
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Thanks.
We could also help fix other callers outside this series.
(this one is put here as it helps this optimization feature avoid that
issue).
Best,
Wei
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-12-14 6:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 8:24 [virtio-dev] [PATCH v11 0/7] virtio-balloon: free page hint support Wei Wang
2018-12-11 8:24 ` [virtio-dev] [PATCH v11 1/7] bitmap: fix bitmap_count_one Wei Wang
[not found] ` <20181213142800.GO2313@work-vm>
2018-12-14 6:37 ` Wei Wang [this message]
2018-12-11 8:24 ` [virtio-dev] [PATCH v11 2/7] bitmap: bitmap_count_one_with_offset Wei Wang
2018-12-11 8:24 ` [virtio-dev] [PATCH v11 3/7] migration: use bitmap_mutex in migration_bitmap_clear_dirty Wei Wang
2018-12-11 8:24 ` [virtio-dev] [PATCH v11 4/7] migration: API to clear bits of guest free pages from the dirty bitmap Wei Wang
2018-12-11 8:24 ` [virtio-dev] [PATCH v11 5/7] migration/ram.c: add a notifier chain for precopy Wei Wang
2018-12-11 8:24 ` [virtio-dev] [PATCH v11 6/7] migration/ram.c: add the free page optimization enable flag Wei Wang
2018-12-11 8:24 ` [virtio-dev] [PATCH v11 7/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang
2019-03-05 14:50 ` [virtio-dev] Re: [Qemu-devel] " Dr. David Alan Gilbert
2019-03-06 2:04 ` Wei Wang
2018-12-14 21:03 ` [virtio-dev] Re: [PATCH v11 0/7] virtio-balloon: free page hint support Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C134FAE.9030300@intel.com \
--to=wei.w.wang@intel.com \
--cc=dgilbert@redhat.com \
--cc=liliang.opensource@gmail.com \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=riel@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox