From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1199CA0ECA for ; Tue, 12 Sep 2023 10:28:16 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 2E702157EF1 for ; Tue, 12 Sep 2023 10:28:16 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 1FB2B9865CA for ; Tue, 12 Sep 2023 10:28:16 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 138B1986485; Tue, 12 Sep 2023 10:28:16 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 038F298648C; Tue, 12 Sep 2023 10:28:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="358610695" X-IronPort-AV: E=Sophos;i="6.02,139,1688454000"; d="scan'208";a="358610695" X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10830"; a="720350911" X-IronPort-AV: E=Sophos;i="6.02,139,1688454000"; d="scan'208";a="720350911" Message-ID: <61a39f1d-ddcc-7381-1d20-d30deca23f7b@intel.com> Date: Tue, 12 Sep 2023 18:28:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.15.0 Content-Language: en-US To: Parav Pandit , Jason Wang Cc: "Michael S. Tsirkin" , "eperezma@redhat.com" , "cohuck@redhat.com" , "stefanha@redhat.com" , "virtio-comment@lists.oasis-open.org" , "virtio-dev@lists.oasis-open.org" References: <20230906081637.32185-1-lingshan.zhu@intel.com> <2b3e8da1-5cbb-f990-0c1d-c0e894a73486@intel.com> <17514b93-2da4-42b3-a5bf-b96358a7a875@intel.com> <9fabd346-9b6f-a727-3de8-813ec3570772@intel.com> <2baee870-bf38-5d83-0543-1d0a68f8e651@intel.com> <8bd1c228-856a-9454-752d-750997c4f4db@intel.com> <4c195683-0eb8-5e92-d97a-217cfa8af760@intel.com> From: "Zhu, Lingshan" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [virtio-dev] Re: [virtio-comment] [PATCH 5/5] virtio-pci: implement VIRTIO_F_QUEUE_STATE On 9/12/2023 6:16 PM, Parav Pandit wrote: >> From: Zhu, Lingshan >> Sent: Tuesday, September 12, 2023 3:45 PM >> >> On 9/12/2023 5:35 PM, Parav Pandit wrote: >>>> From: Zhu, Lingshan >>>> Sent: Tuesday, September 12, 2023 2:38 PM >>>> supplementary: As Jason ever pointed out: the two solution can >>>> co-exist for sure, I am implementing basic facilities, admin vq can >>>> free feel to reuse them like forwarding messages to them, and this can help >> support nested. >>> Sure. Sounds good. >>> >>> At lest two device vendors + other industry bodies including led by Intel are >> moving away from the register-based implementation in virtualization area. >> This series is self-contained, it is an register based solution. It introduces basic >> facilities, doesn't depend on others like AQ. >>> And registers that you expose are not supporting device reset and FLR >> sequence. So please add some text for that in PCI transport section about >> violation. >>> And guideline for driver on how it should not touch them to make this usable. >>> This will make the nested solution more clear. >> PCI FLR is out of this scope, for virtio you can still reset the device by writing 0. >>> Do you find the administration commands we proposed in [1] useful for >> nested case? >>> If not, both will likely diverge. >> Not till now. >>> We would like to avoid suspending individual VQs in the passthrough case, as >> things are controlled at the device level. >>> It also reduces driver -> device interaction for large queue count ranging from >> 1 to 32K. >>> So at present I see very little overlap between the two. I will look more again >> on 9/13 if passthrough proposal can utilize anything from your series. >> It does not suspending an individual VQ, when suspend, all VQs are STOPPED. > We need to stop configuration notifications as well and shared memory update etc. already did if you have read my series --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org