[virtio-dev] Re: [PATCH v11 02/10] admin: introduce device group and related concepts

Stefan Hajnoczi
2023-04-04T11:38:27Z

[-- Attachment #1: Type: text/plain, Size: 1844 bytes --]

On Mon, Apr 03, 2023 at 11:03:09AM -0400, Michael S. Tsirkin wrote:
> Each device group has a type. For now, define one initial group type:
>
> SR-IOV type - PCI SR-IOV virtual functions (VFs) of a given
> PCI SR-IOV physical function (PF). This group may contain zero or more
> virtio devices according to NumVFs configured.
>
> Each device within a group has a unique identifier. This identifier
> is the group member identifier.
>
> Note: one can argue both ways whether the new device group handling
> functionality (this and following patches) is closer
> to a new device type or a new transport type.
>
> However, I expect that we will add more features in the near future. To
> facilitate this as much as possible of the text is located in the new
> admin chapter.
>
> I did my best to minimize transport-specific text.
>
> There's a bit of duplication with 0x1 repeated twice and
> no special section for group type identifiers.
> I think it's ok to defer adding these until we have more group
> types.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> changes in v11:
> dropped Max's S.O.B.
> dropped an unmatched ) as reported by Parav
> document that member id is 1 to numvfs
> document that vf enable must be set (will also be reflected in
> the conformance section)
> document that we deferred generalizing text as requested by Parav -
> I think we can do it later
> minor wording fixes to address comments by David
> add concepts of owner and member driver. unused currently
> but will come in handy later, as suggested by Stefan
> ---
> admin.tex | 63 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> content.tex | 2 ++
> 2 files changed, 65 insertions(+)
> create mode 100644 admin.tex

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]