[virtio-dev] Re: [virtio-comment] Re: [PATCH v11 06/10] mmio: document ADMIN_VQ as reserved

Michael S. Tsirkin
2023-04-24T15:39:08Z

On Mon, Apr 03, 2023 at 11:54:04AM -0400, Parav Pandit wrote:
>
>
> On 4/3/2023 11:03 AM, Michael S. Tsirkin wrote:
> > Adding relevant registers needs more work and it's not
> > clear what the use-case will be as currently only
> > the PCI transport is supported. But let's keep the
> > door open on this.
> > We already say it's reserved in a central place, but it
> > does not hurt to remind implementers to mask it.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Reviewed-by: Parav Pandit <parav@nvidia.com>
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > content.tex | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/content.tex b/content.tex
> > index 5057df2..f7446bf 100644
> > --- a/content.tex
> > +++ b/content.tex
> > @@ -2364,6 +2364,18 @@ \subsection{Legacy interface}\label{sec:Virtio Transport Options / Virtio Over M
> > Notification mechanisms did not change.
> > +\subsection{Features reserved for future use}\label{sec:Virtio Transport Options / Virtio Over MMIO / Features reserved for future use}
> > +
> > +At this time, devices and drivers utilizing Virtio Over MMIO
> No need to mention, "At this time".
> It is always spec version to version.
> And "current time" of the spec is visible in its version.
> Please remove "At this time".
>
> > +do not support the following features:
> > +\begin{itemize}
> > +
> > +\item VIRTIO_F_ADMIN_VQ
> > +
> > +\end{itemize}
> > +
> > +These features are reserved for future use.
> > +
> Above line should be moved up before listing the features.
> or should be written as
> s/These/Above
>
> like, Above listed features are reserved for future use.

I don't feel it matters. And
we were asked to reduce the use of "below" and "above" in new text
as disrespectful to people using screen readers and such.

> > \section{Virtio Over Channel I/O}\label{sec:Virtio Transport Options / Virtio Over Channel I/O}
> > S/390 based virtual machines support neither PCI nor MMIO, so a
>
> Reviewed-by: Parav Pandit <parav@nvidia.com>
>
> This publicly archived list offers a means to provide input to the
> OASIS Virtual I/O Device (VIRTIO) TC.
>
> In order to verify user consent to the Feedback License terms and
> to minimize spam in the list archive, subscription is required
> before posting.
>
> Subscribe: virtio-comment-subscribe@lists.oasis-open.org
> Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
> List help: virtio-comment-help@lists.oasis-open.org
> List archive: https://lists.oasis-open.org/archives/virtio-comment/
> Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
> List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
> Committee: https://www.oasis-open.org/committees/virtio/
> Join OASIS: https://www.oasis-open.org/join/