From: Heng Qi <hengqi@linux.alibaba.com>
To: Parav Pandit <parav@nvidia.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Alvaro Karsz <alvaro.karsz@solid-run.com>,
David Edmondson <david.edmondson@oracle.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Cornelia Huck <cohuck@redhat.com>
Subject: Re: [virtio-dev] RE: [PATCH v6] virtio-net: support the virtqueue coalescing moderation
Date: Wed, 22 Feb 2023 23:21:16 +0800 [thread overview]
Message-ID: <65f968f0-36b7-7fe6-8a18-e590d7657baa@linux.alibaba.com> (raw)
In-Reply-To: <PH0PR12MB548187AB51323E8687FFC708DCAA9@PH0PR12MB5481.namprd12.prod.outlook.com>
Hi, Parav.
在 2023/2/22 下午10:28, Parav Pandit 写道:
>
>> From: Michael S. Tsirkin <mst@redhat.com>
>> Sent: Wednesday, February 22, 2023 1:29 AM
>>> MMIO device has vq_index register too.
>>> I am inclined to vq_index given current state of spec
>> [mst@tuck virtio]$ git grep vq_index|wc -l
>> 0
>>
> :)
>
> Grep for "virtqueue index".
> We need to change "virtqueue index" to "virtqueue number".
Yes, this is more unified in the spec. :)
This version is closed, please help review the v7 version [1] if you
have time.
[1] https://lists.oasis-open.org/archives/virtio-dev/202302/msg00520.html
Thanks very much for your response!
>
>>> and new additions by Michael.
>> admin vq? Good point, I will change that to vqn too.
> Ok. sounds good.
>
>>> Michael,
>>> Can you please suggest vqn or vq_index to use?
>> [mst@tuck virtio]$ git grep vqn|wc -l
>> 5
>>
>> I'd say vqn has precedent.
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-02-22 15:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 3:21 [PATCH v6] virtio-net: support the virtqueue coalescing moderation Heng Qi
2023-02-22 4:13 ` Parav Pandit
2023-02-22 5:31 ` [virtio-dev] " Heng Qi
2023-02-22 6:29 ` Michael S. Tsirkin
2023-02-22 6:49 ` [virtio-comment] " Heng Qi
2023-02-22 14:28 ` [virtio-comment] " Parav Pandit
2023-02-22 15:21 ` Heng Qi [this message]
2023-02-23 10:01 ` [virtio-comment] " David Edmondson
2023-02-22 8:09 ` [virtio-comment] " Alvaro Karsz
2023-02-22 8:32 ` Heng Qi
2023-02-22 11:48 ` Michael S. Tsirkin
2023-02-22 12:50 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65f968f0-36b7-7fe6-8a18-e590d7657baa@linux.alibaba.com \
--to=hengqi@linux.alibaba.com \
--cc=alvaro.karsz@solid-run.com \
--cc=cohuck@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox