From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-2726-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id 13FAF581912F for ; Wed, 29 Nov 2017 07:14:35 -0800 (PST) From: Jean-Philippe Brucker References: <20171117185211.32593-1-jean-philippe.brucker@arm.com> <20171117185211.32593-2-jean-philippe.brucker@arm.com> Message-ID: <73427923-e62a-e277-42a2-cd37141fa122@arm.com> Date: Wed, 29 Nov 2017 15:17:40 +0000 MIME-Version: 1.0 In-Reply-To: <20171117185211.32593-2-jean-philippe.brucker@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [virtio-dev] [RFC PATCH v2 1/5] iommu: Add virtio-iommu driver To: "iommu@lists.linux-foundation.org" , "devel@acpica.org" , "linux-acpi@vger.kernel.org" , "kvm@vger.kernel.org" , "kvmarm@lists.cs.columbia.edu" , "virtualization@lists.linux-foundation.org" , "virtio-dev@lists.oasis-open.org" Cc: "jasowang@redhat.com" , "mst@redhat.com" , "lv.zheng@intel.com" , "robert.moore@intel.com" , "joro@8bytes.org" , "alex.williamson@redhat.com" , Sudeep Holla , "hanjun.guo@linaro.org" , Lorenzo Pieralisi , "lenb@kernel.org" , "rjw@rjwysocki.net" , Marc Zyngier , Robin Murphy , Will Deacon , "eric.auger@redhat.com" , "bharat.bhushan@nxp.com" , "Jayachandran.Nair@cavium.com" , "ashok.raj@intel.com" , "peterx@redhat.com" List-ID: On 17/11/17 18:52, Jean-Philippe Brucker wrote: [...] > +struct viommu_domain { > + struct iommu_domain domain; > + struct viommu_dev *viommu; > + struct mutex mutex; > + unsigned int id; > + > + spinlock_t mappings_lock; > + struct rb_root_cached mappings; > + > + /* Number of endpoints attached to this domain */ > + refcount_t endpoints; Refcount_t is the wrong tool for this, I went back to an unsigned int (and rebased onto v4.15-rc1), on branch virtio-iommu/base. Thanks, Jean --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org