[virtio-dev] Re: [virtio-comment] Re: [PATCH v2 0/2] transport-pci: Introduce legacy registers access using AQ

Michael S. Tsirkin
2023-05-16T21:57:02Z

On Tue, May 16, 2023 at 09:49:19PM +0000, Parav Pandit wrote:
>
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Tuesday, May 16, 2023 5:12 PM
>
> >
> > Nah, we don't need a "break randomly unless it's a full moon and you cross your
> > heart three times" mode. If you are going to implement support for legacy
> > emulation implement it in a way that either predictably works or predictably
> > refuses to load.
>
> It works with same level of predictability as current legacy interface definition for x86_64 platform when msix in guest is supported.
>
> Supporting intx we discussed to deal incrementally after this.

Only thing I am worried is that we do not decide to go back
to msix vector after all because of the shifting offset
of device config. As I said, split device and transport
configs to separate commands rather than just using offset
and then I think it's ok to defer INTx work a bit.

Though I feel it's valuable and will help us move towards
more important goals like LM.
--
MST