[virtio-dev] Re: [PATCH] virtio: i2c: Allow buffer less transactions

[Cornelia Huck <cohuck@redhat.com>]

On Fri, Aug 06 2021, Viresh Kumar <viresh.kumar@linaro.org> wrote:

> On 23-07-21, 10:56, Viresh Kumar wrote:
>> The I2C protocol allows requests with no data, like the SMBus Quick
>> command, where the command is inferred based on the read/write flag
>> itself.
>> 
>> In order to allow such a request, allocate another bit,
>> VIRTIO_I2C_FLAGS_M_RD(1), in the flags to pass the request type, as read
>> or write. This was earlier done using the read/write permission to the
>> buffer itself.
>> 
>> This still won't work well if multiple buffers are passed for the same
>> request, i.e. the write-read requests, as the VIRTIO_I2C_FLAGS_M_RD flag
>> can only be used with a single buffer.
>> 
>> Coming back to it, there is no need to send multiple buffers with a
>> single request. All we need, is a way to group several requests
>> together, which we can already do based on the
>> VIRTIO_I2C_FLAGS_FAIL_NEXT flag.
>> 
>> Remove support for multiple buffers within a single request.
>> 
>> Since we are at very early stage of development currently, we can do
>> these modifications without addition of new features or versioning of
>> the protocol.
>> 
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>
> Gentle reminder!

Hm, I thought there had been some feedback already? I've been waiting
for a respin.


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org