From: Cornelia Huck <cohuck@redhat.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Jie Deng" <jie.deng@intel.com>, "Wolfram Sang" <wsa@kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Jason Wang" <jasowang@redhat.com>,
"Bill Mills" <bill.mills@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
virtio-dev@lists.oasis-open.org, stratos-dev@op-lists.linaro.org,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Arnd Bergmann" <arnd@kernel.org>
Subject: [virtio-dev] Re: [PATCH V5 2/2] virtio: i2c: Allow zero-length transactions
Date: Wed, 13 Oct 2021 13:10:48 +0200 [thread overview]
Message-ID: <8735p5w56v.fsf@redhat.com> (raw)
In-Reply-To: <20211013104359.wykpyaz5cffgefuu@vireshk-i7>
On Wed, Oct 13 2021, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 13-10-21, 11:26, Cornelia Huck wrote:
>> On Tue, Oct 12 2021, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>> > +A device SHOULD implement the VIRTIO_I2C_F_ZERO_LENGTH_REQUEST feature.
>>
>> Same here, I would make this "MUST offer", and simply make old device
>> implementations non-compliant.
>
>> The device should also reject any driver that does not negotiate the
>> flag, I think?
>
> Thinking about this a bit more, in practice the device doesn't get to
> know about what the driver does with the flag. So how can a device
> reject the driver ?
It can fail setting FEATURES_OK, if the driver does not set the feature.
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2021-10-13 11:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 11:23 [PATCH V5 0/2] virtio: i2c: Allow zero-length transactions Viresh Kumar
2021-10-12 11:23 ` [PATCH V5 1/2] virtio: i2c: No need to have separate read-write buffers Viresh Kumar
2021-10-12 13:58 ` Arnd Bergmann
2021-10-12 11:23 ` [PATCH V5 2/2] virtio: i2c: Allow zero-length transactions Viresh Kumar
2021-10-12 14:09 ` Arnd Bergmann
2021-10-13 2:32 ` [virtio-dev] " Jie Deng
2021-10-13 3:39 ` Viresh Kumar
2021-10-13 4:07 ` [virtio-dev] " Jie Deng
2021-10-13 4:12 ` Viresh Kumar
2021-10-13 9:26 ` [virtio-dev] " Cornelia Huck
2021-10-13 9:33 ` Viresh Kumar
2021-10-13 9:44 ` [virtio-dev] " Cornelia Huck
2021-10-13 10:43 ` Viresh Kumar
2021-10-13 11:10 ` Cornelia Huck [this message]
2021-10-13 2:25 ` [PATCH V5 0/2] " Jie Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735p5w56v.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=arnd@kernel.org \
--cc=bill.mills@linaro.org \
--cc=jasowang@redhat.com \
--cc=jie.deng@intel.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stratos-dev@op-lists.linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox