Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Parav Pandit <parav@nvidia.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: "virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	Shahaf Shuler <shahafs@nvidia.com>,
	David Edmondson <david.edmondson@oracle.com>
Subject: [virtio-dev] Re: [virtio-comment] RE: [PATCH v6] virtio-net: Improve introductory description
Date: Thu, 16 Feb 2023 17:30:09 +0100	[thread overview]
Message-ID: <87a61da7zi.fsf@redhat.com> (raw)
In-Reply-To: <PH0PR12MB54814F1CCBA0CD40A4908274DCA09@PH0PR12MB5481.namprd12.prod.outlook.com>

On Thu, Feb 16 2023, Parav Pandit <parav@nvidia.com> wrote:

>> From: Cornelia Huck <cohuck@redhat.com>
>> Sent: Thursday, February 16, 2023 11:03 AM
>> 
>> On Thu, Feb 16 2023, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>> 
>> > On Thu, Feb 16, 2023 at 02:30:03PM +0000, Parav Pandit wrote:
>> >>
>> >> > From: Cornelia Huck <cohuck@redhat.com>
>> >> > Sent: Thursday, February 16, 2023 9:10 AM
>> >> >
>> >> > On Tue, Feb 14 2023, Parav Pandit <parav@nvidia.com> wrote:
>> >> >
>> >> > > The control VQ of the virtio network device is used beyond
>> >> > > advance steering control. The control VQ dynamically changes
>> >> > > multiple features of the initialized device.
>> >> > >
>> >> > > Hence, update this area of control VQ introductory description at
>> >> > > few places and also place the link to its description.
>> >> > >
>> >> > > Also update the introduction section to better describe receive
>> >> > > and transmit virtqueues.
>> >> > >
>> >> > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/156
>> >> > > Reviewed-by: David Edmondson <david.edmondson@oracle.com>
>> >> > > Signed-off-by: Parav Pandit <parav@nvidia.com>
>> >> >
>> >> > Are you requesting a vote for this?
>> >>
>> >> I was not sure if its need voting as most are editorial cleanups, better
>> description, structure movement.
>> >> Please advise if we need voting.
>> >
>> >
>> > The bylaws are here:
>> > https://github.com/oasis-tcs/virtio-spec/blob/master/README.md
>> > Minor cleanups, including editorial formatting changes, spelling and
>> > typo fixes can be committed directly into git for approval as part of
>> > the next specification approval ballot.
>> >
>> > This is way beyond that. And generally when in doubt vote.
>> 
>> Agreed.
>> 
>> (Btw: the github issue needs to be updated to point to the latest version of the
>> patch, it still points to v1.)
>
> Done.

Do you request to withdraw the ballot, so that we can start a new ballot
with the proper URL?

(Sorry about being a stickler for process here.)


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2023-02-16 16:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 18:04 [PATCH v6] virtio-net: Improve introductory description Parav Pandit
2023-02-16 14:09 ` [virtio-comment] " Cornelia Huck
2023-02-16 14:30   ` Parav Pandit
2023-02-16 15:49     ` Michael S. Tsirkin
2023-02-16 16:00       ` [virtio-comment] " Parav Pandit
2023-02-16 16:02         ` Parav Pandit
2023-02-16 16:03       ` [virtio-comment] " Cornelia Huck
2023-02-16 16:05         ` [virtio-comment] " Parav Pandit
2023-02-16 16:30           ` Cornelia Huck [this message]
2023-02-17  2:59             ` [virtio-dev] " Parav Pandit
2023-02-20 13:34               ` [virtio-comment] " Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a61da7zi.fsf@redhat.com \
    --to=cohuck@redhat.com \
    --cc=david.edmondson@oracle.com \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox