From: Cornelia Huck <cohuck@redhat.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>,
virtio-comment@lists.oasis-open.org,
virtio-dev@lists.oasis-open.org
Cc: jasowang@redhat.com, mst@redhat.com,
Alvaro Karsz <alvaro.karsz@solid-run.com>
Subject: Re: [virtio-dev] [PATCH v3] virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET_F_CTRL_VQ
Date: Mon, 20 Feb 2023 15:21:41 +0100 [thread overview]
Message-ID: <87fsb0l8ne.fsf@redhat.com> (raw)
In-Reply-To: <20230206080210.37758-1-alvaro.karsz@solid-run.com>
On Mon, Feb 06 2023, Alvaro Karsz <alvaro.karsz@solid-run.com> wrote:
> If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may
> send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ
> feature should be negotiated.
>
> ---
> v2: Use SHOULD instead of Feature bit requirement, version 1.2 is already
> out and doesn't include this depencency.
>
> v3: Explain the dependency in a less confusing way.
>
> Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
Minor nit (for the next time, was trivial to fix up): Putting your s-o-b
beneath the "---" instructs git am to cut it off; the changelog should
go below the s-o-b.
>
> device-types/net/description.tex | 6 ++++++
> 1 file changed, 6 insertions(+)
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-02-20 14:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 8:02 [virtio-dev] [PATCH v3] virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET_F_CTRL_VQ Alvaro Karsz
2023-02-06 22:02 ` [virtio-comment] " Parav Pandit
2023-02-07 7:54 ` Alvaro Karsz
2023-02-07 14:12 ` [virtio-comment] " Michael S. Tsirkin
2023-02-08 10:42 ` [virtio-dev] " Alvaro Karsz
2023-02-10 11:38 ` Alvaro Karsz
2023-02-10 18:42 ` [virtio-dev] " Parav Pandit
2023-02-11 9:12 ` Alvaro Karsz
2023-02-11 14:03 ` Parav Pandit
2023-02-12 9:38 ` Michael S. Tsirkin
2023-02-14 0:50 ` [virtio-comment] " Parav Pandit
2023-02-20 14:21 ` Cornelia Huck [this message]
2023-02-20 14:25 ` [virtio-dev] " Alvaro Karsz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsb0l8ne.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox