Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	Virtio-Dev <virtio-dev@lists.oasis-open.org>
Subject: Re: [virtio-dev] [PATCH v3 2/2] virtio: pci support virtqueue reset
Date: Tue, 28 Sep 2021 11:22:03 +0200	[thread overview]
Message-ID: <87fstp5a2s.fsf@redhat.com> (raw)
In-Reply-To: <CACGkMEvSa6Q=BpMsOKR7Ax+tRGikm=hxGCb3rxDAFzOCN1OPhA@mail.gmail.com>

On Tue, Sep 28 2021, Jason Wang <jasowang@redhat.com> wrote:

> On Mon, Sep 27, 2021 at 10:51 PM Cornelia Huck <cohuck@redhat.com> wrote:
>> For CCW, maybe we can add a payload to the existing RESET command if the
>> feature has been negotiated;
>
> I wonder if it's better for a new dedicated command. Consider device
> reset is different from virtqueue reset.

Yes, either can work. I'm trying to be a bit conservative with
allocating new commands, but if it is too confusing, we can use a new
one. The important thing is that I think this can be implemented for ccw
as well.

>
> Thanks
>
>> the queue can be re-enabled by the normal
>> READ_VQ_CONF/SET_VQ procedure. I have not yet thought that through.


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2021-09-28  9:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 12:31 [virtio-dev] [PATCH v3 0/2] virtio: introduce VIRTIO_F_RING_RESET for reset queue Xuan Zhuo
2021-09-27 12:31 ` [virtio-dev] [PATCH v3 1/2] virtio: introduce virtqueue reset as basic facility Xuan Zhuo
2021-09-27 14:37   ` Cornelia Huck
2021-09-28  2:47     ` Xuan Zhuo
2021-09-28  3:01   ` [virtio-dev] " Jason Wang
2021-09-28  3:03     ` Xuan Zhuo
2021-09-27 12:31 ` [virtio-dev] [PATCH v3 2/2] virtio: pci support virtqueue reset Xuan Zhuo
2021-09-27 14:51   ` Cornelia Huck
2021-09-28  3:02     ` Jason Wang
2021-09-28  9:22       ` Cornelia Huck [this message]
2021-09-28  6:48     ` Xuan Zhuo
2021-09-28  9:26       ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fstp5a2s.fsf@redhat.com \
    --to=cohuck@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox