From: Cornelia Huck <cohuck@redhat.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>, mst@redhat.com
Cc: jasowang@redhat.com, virtio-comment@lists.oasis-open.org,
hengqi@linux.alibaba.com, parav@nvidia.com,
"virtio-dev @ lists . oasis-open . org"
<virtio-dev@lists.oasis-open.org>
Subject: Re: [virtio-dev] Re: [PATCH] virtio-net: define the VIRTIO_NET_F_CTRL_RX_EXTRA feature bit
Date: Mon, 20 Feb 2023 11:25:16 +0100 [thread overview]
Message-ID: <87o7poljlf.fsf@redhat.com> (raw)
In-Reply-To: <CAJs=3_B7sU=Y9qAc80S6obysN0fYaNX-tdexATTPOu1qv-38Gw@mail.gmail.com>
On Mon, Feb 20 2023, Alvaro Karsz <alvaro.karsz@solid-run.com> wrote:
> I didn't add the control vq feature as a feature bit requirement for
> the same reason as [1].
>
> If you think that we can add a feature bit requirement instead of
> "SHOULD NOT offer" and "SHOULD NOT negotiate", I can add it in v2.
>
> [1] https://github.com/oasis-tcs/virtio-spec/issues/158
I agree that we need to stick with SHOULD here.
Are VIRTIO_NET_F_CTRL_RX_EXTRA and VIRTIO_NET_F_CTRL_RX independent of
each other, i.e. can you negotiate VIRTIO_NET_F_CTRL_RX_EXTRA but not
VIRTIO_NET_F_CTRL_RX? Looks like it to me, but would like to confirm.
(We would at most be able to add a SHOULD statement anyway.)
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-02-20 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 9:35 [virtio-dev] [PATCH] virtio-net: define the VIRTIO_NET_F_CTRL_RX_EXTRA feature bit Alvaro Karsz
2023-02-20 9:40 ` [virtio-dev] " Alvaro Karsz
2023-02-20 10:25 ` Cornelia Huck [this message]
2023-02-20 11:15 ` Alvaro Karsz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7poljlf.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox