Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Cc: virtio-dev@lists.oasis-open.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Dan Williams <dan.j.williams@intel.com>,
	David Hildenbrand <david@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Taylor Stark <tstark@linux.microsoft.com>,
	Pankaj Gupta <pankaj.gupta@ionos.com>
Subject: Re: [virtio-dev] Re: [PATCH v5] virtio-pmem: PMEM device spec
Date: Wed, 06 Oct 2021 12:17:25 +0200	[thread overview]
Message-ID: <87pmsizccq.fsf@redhat.com> (raw)
In-Reply-To: <CAM9Jb+jtYgyPrgVaHV-c5PPE8yLoJKhU-r+XWYx6qruMrmEgiA@mail.gmail.com>

On Wed, Oct 06 2021, Pankaj Gupta <pankaj.gupta.linux@gmail.com> wrote:

>> >> > +\subsubsection{ Workload specific mapping}\label{sec:Device Types / PMEM Device / Possible Security Implications / Countermeasures / Workload}
>> >> > +For SHARED mappings, for the workload is a single application inside
>> >> > +the driver and there is no risk in sharing data. Device sharing
>> >>
>> >> Sorry for noticing this only now, but I have trouble parsing this
>> >> sentence. Does it mean that you can use SHARED mapping if the workload
>> >> is a single application?
>> >
>> > yes and if risk in sharing data is very less or acceptable.
>> >
>> >>
>> >> > +same backing region with SHARED mapping can be used as a valid configuration.
>>
>> Hm... maybe rephrase this paragraph as:
>>
>> "When using SHARED mappings with a workload that is a single application
>> inside the driver where the risk in sharing data is very low or
>> nonexisting, the device sharing the same backing region with a SHARED
>> mapping can be used as a valid configuration."
>
> Thank you Cornelia!
> I tried to reread my initial statement and I think that also precisely conveys
> the use-case.
>
> If you are okay, I will respin v6 with only space with bracket change
> and Stefan r-o-b?

And my proposed change? If nobody else has a comment, I think we could
start voting on that.


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2021-10-06 10:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06  6:21 [PATCH v5] virtio-pmem: PMEM device spec Pankaj Gupta
2021-10-06  7:09 ` [virtio-dev] " Cornelia Huck
2021-10-06  7:19   ` Pankaj Gupta
2021-10-06  7:21   ` [virtio-dev] " Pankaj Gupta
2021-10-06  8:34     ` Cornelia Huck
2021-10-06 10:02       ` Pankaj Gupta
2021-10-06 10:17         ` Cornelia Huck [this message]
2021-10-06 10:24           ` Pankaj Gupta
2021-10-06  9:17 ` [virtio-dev] " Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmsizccq.fsf@redhat.com \
    --to=cohuck@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=david@redhat.com \
    --cc=mst@redhat.com \
    --cc=pankaj.gupta.linux@gmail.com \
    --cc=pankaj.gupta@ionos.com \
    --cc=stefanha@redhat.com \
    --cc=tstark@linux.microsoft.com \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox