Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Heng Qi <hengqi@linux.alibaba.com>,
	virtio-dev@lists.oasis-open.org,
	virtio-comment@lists.oasis-open.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
	Parav Pandit <parav@nvidia.com>, Jason Wang <jasowang@redhat.com>,
	Alvaro Karsz <alvaro.karsz@solid-run.com>,
	David Edmondson <david.edmondson@oracle.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [virtio-dev] Re: [PATCH v13] virtio-net: support the virtqueue coalescing moderation
Date: Wed, 22 Mar 2023 16:20:33 +0100	[thread overview]
Message-ID: <87sfdwhkxq.fsf@redhat.com> (raw)
In-Reply-To: <20230322125153.128385-1-hengqi@linux.alibaba.com>

On Wed, Mar 22 2023, Heng Qi <hengqi@linux.alibaba.com> wrote:

> +The driver MUST NOT set \field{vqn} to any value other than an enabled transmit or receive virtqueue number.

"than the virtqueue number of an enabled transmit or receive virtqueue"

might be better -- what do others think?

Otherwise, LGTM.


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2023-03-22 15:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 12:51 [virtio-dev] [PATCH v13] virtio-net: support the virtqueue coalescing moderation Heng Qi
2023-03-22 15:20 ` Cornelia Huck [this message]
2023-03-22 16:23   ` [virtio-dev] " Parav Pandit
2023-03-22 16:36     ` Cornelia Huck
2023-03-22 16:40       ` Parav Pandit
2023-03-22 16:44         ` [virtio-dev] Re: [virtio-comment] " Cornelia Huck
2023-03-22 16:46           ` [virtio-dev] " Parav Pandit
2023-03-22 16:50             ` [virtio-dev] " Michael S. Tsirkin
2023-03-22 16:46           ` Michael S. Tsirkin
2023-03-22 16:49             ` [virtio-dev] " Parav Pandit
2023-03-22 16:53               ` [virtio-dev] " Michael S. Tsirkin
2023-03-22 17:02                 ` [virtio-dev] " Parav Pandit
2023-03-23  2:26                   ` Heng Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfdwhkxq.fsf@redhat.com \
    --to=cohuck@redhat.com \
    --cc=alvaro.karsz@solid-run.com \
    --cc=david.edmondson@oracle.com \
    --cc=hengqi@linux.alibaba.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox