From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 542AE98640B for ; Tue, 8 Nov 2022 19:13:56 +0000 (UTC) Message-ID: <9008244e-10ea-7983-50da-4716e213d119@opensynergy.com> Date: Tue, 8 Nov 2022 20:13:51 +0100 References: <20221104172421.8271-1-Harald.Mommer@opensynergy.com> <20221104172421.8271-3-Harald.Mommer@opensynergy.com> From: Harald Mommer In-Reply-To: MIME-Version: 1.0 Subject: [virtio-dev] Re: [RFC PATCH v2 2/2] can: virtio: Add virtio_can to MAINTAINERS file. Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Vincent Mailhol , Harald Mommer Cc: virtio-dev@lists.oasis-open.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wolfgang Grandegger , Marc Kleine-Budde , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Dariusz Stojaczyk List-ID: Hello Vincent, what I see here are places from v1 which should be now obsolete and of no further interest. There was a patch v1, this has been reworked and now comes v2 which supersedes v1. Squashing is something I could do if I had 2 commits which should be joined together but here is probably not meant to squash the virtio_can.[ch] code file commit with the MAINTAINERS file commit. Could be that I misunderstood the way how is worked with patches on the mailing lists, don't know. I do absolutely not understand what you mean here. Regards Harald On 05.11.22 11:14, Vincent Mailhol wrote: > On Sat. 5 Nov. 2022 at 02:29, Harald Mommer > wrote: >> From: Harald Mommer >> >> Signed-off-by: Harald Mommer >> --- >> MAINTAINERS | 7 +++++++ >> drivers/net/can/virtio_can.c | 6 ++---- >> 2 files changed, 9 insertions(+), 4 deletions(-) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 379945f82a64..01b2738b7c16 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -21692,6 +21692,13 @@ F: drivers/vhost/scsi.c >> F: include/uapi/linux/virtio_blk.h >> F: include/uapi/linux/virtio_scsi.h >> >> +VIRTIO CAN DRIVER >> +M: "Harald Mommer" >> +L: linux-can@vger.kernel.org >> +S: Maintained >> +F: drivers/net/can/virtio_can.c >> +F: include/uapi/linux/virtio_can.h >> + >> VIRTIO CONSOLE DRIVER >> M: Amit Shah >> L: virtualization@lists.linux-foundation.org >> diff --git a/drivers/net/can/virtio_can.c b/drivers/net/can/virtio_can.c >> index 43cf1c9e4afd..0e87172bbddf 100644 >> --- a/drivers/net/can/virtio_can.c >> +++ b/drivers/net/can/virtio_can.c >> @@ -1,7 +1,7 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +// SPDX-License-Identifier: GPL-2.0-only > Please squash this in the previous patch. > >> /* >> * CAN bus driver for the Virtio CAN controller >> - * Copyright (C) 2021 OpenSynergy GmbH >> + * Copyright (C) 2021-2022 OpenSynergy GmbH > Same. > >> */ >> >> #include >> @@ -793,8 +793,6 @@ static void virtio_can_populate_vqs(struct virtio_device *vdev) >> unsigned int idx; >> int ret; >> >> - // TODO: Think again a moment if here locks already may be needed! > Same. > >> /* Fill RX queue */ >> vq = priv->vqs[VIRTIO_CAN_QUEUE_RX]; >> for (idx = 0u; idx < ARRAY_SIZE(priv->rpkt); idx++) { >> -- >> 2.17.1 >> --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org