Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Pankaj Gupta <pagupta@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtio-comment@lists.oasis-open.org,
	virtio-dev@lists.oasis-open.org, virtio@lists.oasis-open.org
Subject: Re: [virtio-dev] [PATCH] virtio-rng: fix device/driver confusion
Date: Mon, 25 Nov 2019 02:36:32 -0500 (EST)	[thread overview]
Message-ID: <928289982.36200800.1574667392106.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20191124124344.262655-1-mst@redhat.com>


> 
> The point of rng is to give data to driver so of course
> all buffers are driver readable. What shouldn't be there
> is device readable buffers - this matches our terminology
> elsewhere too (read/write-ability is from POV of device).
> 
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/55
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Reviewed-by: Pankaj Gupta <pagupta@redhat.com>

> ---
>  content.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/content.tex b/content.tex
> index 678afbe..72e832e 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -4721,7 +4721,7 @@ \subsection{Device Operation}\label{sec:Device Types /
> Entropy Device / Device O
>  
>  \drivernormative{\subsubsection}{Device Operation}{Device Types / Entropy
>  Device / Device Operation}
>  
> -The driver MUST NOT place driver-readable buffers into the queue.
> +The driver MUST NOT place device-readable buffers into the queue.
>  
>  The driver MUST examine the length written by the device to determine
>  how many random bytes were received.
> --
> MST
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


      reply	other threads:[~2019-11-25  7:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-24 12:44 [virtio] [PATCH] virtio-rng: fix device/driver confusion Michael S. Tsirkin
2019-11-25  7:36 ` Pankaj Gupta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=928289982.36200800.1574667392106.JavaMail.zimbra@redhat.com \
    --to=pagupta@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtio@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox