* [virtio] [PATCH] virtio-rng: fix device/driver confusion
@ 2019-11-24 12:44 Michael S. Tsirkin
2019-11-25 7:36 ` [virtio-dev] " Pankaj Gupta
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2019-11-24 12:44 UTC (permalink / raw)
To: virtio-comment, virtio-dev; +Cc: virtio
The point of rng is to give data to driver so of course
all buffers are driver readable. What shouldn't be there
is device readable buffers - this matches our terminology
elsewhere too (read/write-ability is from POV of device).
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/55
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
content.tex | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/content.tex b/content.tex
index 678afbe..72e832e 100644
--- a/content.tex
+++ b/content.tex
@@ -4721,7 +4721,7 @@ \subsection{Device Operation}\label{sec:Device Types / Entropy Device / Device O
\drivernormative{\subsubsection}{Device Operation}{Device Types / Entropy Device / Device Operation}
-The driver MUST NOT place driver-readable buffers into the queue.
+The driver MUST NOT place device-readable buffers into the queue.
The driver MUST examine the length written by the device to determine
how many random bytes were received.
--
MST
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [virtio-dev] [PATCH] virtio-rng: fix device/driver confusion
2019-11-24 12:44 [virtio] [PATCH] virtio-rng: fix device/driver confusion Michael S. Tsirkin
@ 2019-11-25 7:36 ` Pankaj Gupta
0 siblings, 0 replies; 2+ messages in thread
From: Pankaj Gupta @ 2019-11-25 7:36 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: virtio-comment, virtio-dev, virtio
>
> The point of rng is to give data to driver so of course
> all buffers are driver readable. What shouldn't be there
> is device readable buffers - this matches our terminology
> elsewhere too (read/write-ability is from POV of device).
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/55
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Pankaj Gupta <pagupta@redhat.com>
> ---
> content.tex | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/content.tex b/content.tex
> index 678afbe..72e832e 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -4721,7 +4721,7 @@ \subsection{Device Operation}\label{sec:Device Types /
> Entropy Device / Device O
>
> \drivernormative{\subsubsection}{Device Operation}{Device Types / Entropy
> Device / Device Operation}
>
> -The driver MUST NOT place driver-readable buffers into the queue.
> +The driver MUST NOT place device-readable buffers into the queue.
>
> The driver MUST examine the length written by the device to determine
> how many random bytes were received.
> --
> MST
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-25 7:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-24 12:44 [virtio] [PATCH] virtio-rng: fix device/driver confusion Michael S. Tsirkin
2019-11-25 7:36 ` [virtio-dev] " Pankaj Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox