Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Heng Qi <hengqi@linux.alibaba.com>
To: David Edmondson <david.edmondson@oracle.com>
Cc: virtio-dev@lists.oasis-open.org,
	virtio-comment@lists.oasis-open.org,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Parav Pandit <parav@nvidia.com>,
	Alvaro Karsz <alvaro.karsz@solid-run.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Jason Wang <jasowang@redhat.com>
Subject: Re: [virtio-dev] Re: [PATCH v5] virtio-net: support the virtqueue coalescing moderation
Date: Tue, 21 Feb 2023 20:17:24 +0800	[thread overview]
Message-ID: <99460ec7-4afa-7c4a-ff8a-72acf53a05da@linux.alibaba.com> (raw)
In-Reply-To: <m25ybvdyl7.fsf@oracle.com>


在 2023/2/21 下午7:48, David Edmondson 写道:
> On Tuesday, 2023-02-21 at 16:38:52 +08, Heng Qi wrote:
>> ...
>> +A device MAY set the coalescing parameter to a value close to a power of 2 value.
> What is this about?
>
> If it is intended to indicate that a device may use a value different to
> that passed by the driver, more text to describe that would be

Yes. How about adding the following explanation to the "Operation" 
subparagraph?
"
When a device receives the VIRTIO_NET_CTRL_NOTF_COAL commands to set an 
coalescing parameter, it may set the parameter to a value close to a 
power of 2. For example:
If the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with \field{max_usecs} = 
7 is received, the device may set \field{max_usecs} = 8 for a given 
enabled virtqueue.
"

Thanks.

> useful. If not, what does it mean?


      reply	other threads:[~2023-02-21 12:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21  8:38 [PATCH v5] virtio-net: support the virtqueue coalescing moderation Heng Qi
2023-02-21 11:48 ` David Edmondson
2023-02-21 12:17   ` Heng Qi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99460ec7-4afa-7c4a-ff8a-72acf53a05da@linux.alibaba.com \
    --to=hengqi@linux.alibaba.com \
    --cc=alvaro.karsz@solid-run.com \
    --cc=cohuck@redhat.com \
    --cc=david.edmondson@oracle.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox