From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
virtio-comment@lists.oasis-open.org,
virtio-dev@lists.oasis-open.org, virtio@lists.oasis-open.org,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [virtio-comment] Re: [virtio] [PATCH] virtio: clarify feature negotiation
Date: Wed, 26 Jan 2022 09:27:14 +0000 [thread overview]
Message-ID: <YfET8pNaYoWZ6eFt@myrica> (raw)
In-Reply-To: <20220124132837-mutt-send-email-mst@kernel.org>
On Mon, Jan 24, 2022 at 04:42:35PM -0500, Michael S. Tsirkin wrote:
> So from that point of view, we are actually relaxing the requirements,
> and yes we'll need to carefully go over each instance of
> "offered".
> I thought I did, but now I did a quick grep again and I found instances
> in virtio-iommu.tex and virtio-gpio.tex
> Both of these are new, so I think we can just fix them to "negotiated".
>
> Jean-Philippe, Viresh, what do you think? Would it be a problem to
> replace offered with negotiated, and restrict iommu and gpio drivers to
> access config space after FEATURES_OK?
No problem for iommu. The config space fields domain_range and input_range
are not useful to the driver before DRIVER_OK. Reading field bypass
earlier could be useful for debugging, but in that case going a few more
steps into device initialization wouldn't hurt.
Thanks,
Jean
next prev parent reply other threads:[~2022-01-26 9:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 22:50 [virtio-dev] [PATCH] virtio: clarify feature negotiation Michael S. Tsirkin
2022-01-17 15:39 ` Cornelia Huck
2022-01-17 22:26 ` Michael S. Tsirkin
2022-01-19 12:23 ` Halil Pasic
2022-01-19 16:20 ` Michael S. Tsirkin
2022-01-19 17:50 ` [virtio] " Cornelia Huck
2022-01-19 23:48 ` Michael S. Tsirkin
2022-01-20 12:39 ` [virtio-comment] " Cornelia Huck
2022-01-20 15:07 ` Michael S. Tsirkin
2022-01-20 15:24 ` Halil Pasic
2022-01-19 12:23 ` [virtio-comment] Re: [virtio] " Halil Pasic
2022-01-19 16:34 ` Michael S. Tsirkin
2022-01-20 13:05 ` [virtio-dev] " Cornelia Huck
2022-01-20 16:52 ` Michael S. Tsirkin
2022-01-21 2:38 ` Halil Pasic
2022-01-21 16:05 ` [virtio-dev] " Cornelia Huck
2022-01-24 16:40 ` Halil Pasic
2022-01-24 21:42 ` Michael S. Tsirkin
2022-01-25 14:57 ` [virtio] " Cornelia Huck
2022-01-25 18:05 ` Michael S. Tsirkin
2022-01-26 9:27 ` Jean-Philippe Brucker [this message]
2022-04-07 14:28 ` Cornelia Huck
2022-04-07 14:58 ` Michael S. Tsirkin
2022-01-26 15:10 ` Halil Pasic
2022-01-25 15:22 ` [virtio-dev] " Cornelia Huck
2022-01-26 14:14 ` Halil Pasic
2022-01-21 3:17 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfET8pNaYoWZ6eFt@myrica \
--to=jean-philippe@linaro.org \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=viresh.kumar@linaro.org \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox