From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DE96EB64DA for ; Wed, 12 Jul 2023 14:54:30 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 99C1A33590 for ; Wed, 12 Jul 2023 14:54:29 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 8ECEA9867B1 for ; Wed, 12 Jul 2023 14:54:29 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 7817298671F; Wed, 12 Jul 2023 14:54:29 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 62AFD986686; Wed, 12 Jul 2023 14:54:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=hengqi@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VnDR1NP_1689173659; Message-ID: Date: Wed, 12 Jul 2023 22:54:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 To: Cornelia Huck , "Michael S. Tsirkin" Cc: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org, Parav Pandit , Jason Wang , Yuri Benditovich , Xuan Zhuo References: <20230703152711.106008-1-hengqi@linux.alibaba.com> <87pm4xjp4t.fsf@redhat.com> <20230712082508-mutt-send-email-mst@kernel.org> <87jzv5jo82.fsf@redhat.com> <87h6q9jm85.fsf@redhat.com> From: Heng Qi In-Reply-To: <87h6q9jm85.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH v21] virtio-net: support inner header hash 在 2023/7/12 下午9:25, Cornelia Huck 写道: > On Wed, Jul 12 2023, Heng Qi wrote: > >> 在 2023/7/12 下午8:42, Cornelia Huck 写道: >>> On Wed, Jul 12 2023, "Michael S. Tsirkin" wrote: >>> >>>> On Wed, Jul 12, 2023 at 02:22:26PM +0200, Cornelia Huck wrote: >>>>> On Mon, Jul 03 2023, Heng Qi wrote: >>>>> >>>>> (...) >>>>> >>>>>> +\paragraph{Inner Header Hash} >>>>>> +\label{sec:Device Types / Network Device / Device Operation / Processing of Incoming Packets / Inner Header Hash} >>>>>> + >>>>>> +If VIRTIO_NET_F_HASH_TUNNEL has been negotiated, the driver can send the command >>>>>> +VIRTIO_NET_CTRL_HASH_TUNNEL_SET to configure the calculation of the inner header hash. >>>>>> + >>>>>> +struct virtnet_hash_tunnel { >>>>>> + le32 enabled_tunnel_types; >>>>>> +}; >>>>>> + >>>>>> +#define VIRTIO_NET_CTRL_HASH_TUNNEL 7 >>>>>> + #define VIRTIO_NET_CTRL_HASH_TUNNEL_SET 0 >>>>> This needs to be wrapped in \begin{lstlisting}..\end{lstlisting}, can do >>>>> so when applying. >>>>> >>>>> (...) >>>>> >>>>>> +Encapsulation types applicable for inner header hash: >>>>>> +\begin{lstlisting} >>>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_GRE_2784 (1 << 0) /* \hyperref[intro:gre_rfc2784]{[GRE_rfc2784]} */ >>>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_GRE_2890 (1 << 1) /* \hyperref[intro:gre_rfc2890]{[GRE_rfc2890]} */ >>>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_GRE_7676 (1 << 2) /* \hyperref[intro:gre_rfc7676]{[GRE_rfc7676]} */ >>>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_GRE_UDP (1 << 3) /* \hyperref[intro:gre_in_udp_rfc8086]{[GRE-in-UDP]} */ >>>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_VXLAN (1 << 4) /* \hyperref[intro:vxlan]{[VXLAN]} */ >>>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_VXLAN_GPE (1 << 5) /* \hyperref[intro:vxlan_gpe]{[VXLAN-GPE]} */ >>>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_GENEVE (1 << 6) /* \hyperref[intro:geneve]{[GENEVE]} */ >>>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_IPIP (1 << 7) /* \hyperref[intro:ipip]{[IPIP]} */ >>>>>> +#define VIRTIO_NET_HASH_TUNNEL_TYPE_NVGRE (1 << 8) /* \hyperref[intro:nvgre]{[NVGRE]} */ >>>>>> +\end{lstlisting} >>>>> I'm afraid this one doesn't come out quite as intended, we'll end up >>>>> with verbatim "\hyperref" text instead of a link. Anyone have a good >>>>> idea on how to fix that? >>>>> >>>>> I'd prefer to push this now with the first issue addressed and to do an >>>>> (editorial) patch on top to deal with the second issue (unless someone >>>>> can come up with a really trivial fix for it, then I can apply that >>>>> straightaway.) >>>> Someone suggested using escapechar: >>>> https://tex.stackexchange.com/questions/314903/inline-links-in-code-listings >>>> >>>> Didn't try. >>> Looks reasonable (and also revealed a typo for VXLAN-GPE). I think I'll >>> go ahead with this one. >> Yes. "intro:vxlan_gpe" -> "intro:vxlan-gpe". >> >> May I ask if the fix to these two problems is for me to make fix patches >> or for you to solve it when editing? > I'd fix it myself while applying, but... > > ...while the changes above give me a fine pdf, the html generated is > broken. The problem seems to originate in the normative references that > are added in introduction.tex, but I don't see where it goes astray. > > [401] [402] [403] [404] (./virtio-v1.2-cs01.aux > ! Missing \endcsname inserted. > > \unhbox > l.49 ...ction}Normative References}}{section.1}{}} > > ? > ! Emergency stop. > > \unhbox > l.49 ...ction}Normative References}}{section.1}{}} > > (makehtml.sh on master seems to work ok, so it's something in this > patch...) > > Does anyone else manage to spot the problem? The problem is that underline cannot be added directly in \textbf, we need a little modification: \textbf{[GRE_rfc2784]} --> \textbf{[GRE\_rfc2784]} \textbf{[GRE_rfc2890]} --> \textbf{[GRE\_rfc2890]} \textbf{[GRE_rfc7676]} --> \textbf{[GRE\_rfc7676]} After this modification, I can successfully compile pdf on overleaf, please try this. Thanks. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org