From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBB35C7618E for ; Mon, 24 Apr 2023 16:44:22 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 45D506024A for ; Mon, 24 Apr 2023 16:44:22 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 37D7E9863A5 for ; Mon, 24 Apr 2023 16:44:22 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 29A1B986350; Mon, 24 Apr 2023 16:44:22 +0000 (UTC) Mailing-List: contact virtio-dev-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 17B4498635B for ; Mon, 24 Apr 2023 16:44:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: Dg4WACbrNs2QbHdcCLBdnA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682354657; x=1684946657; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uRPHe+pV4jtcPP8Z6jVvfZdO84tz1hdh1EQZ1Z+gTJc=; b=hlSdFHlseUkUkdX9Y4tb27ZDL37GENA1CsYC8eptjFiZGuWUDKAS75x9HBWhBGvqa9 s0Rrln3GAoafqvrBhof99PpPiVAp1ECproTRHyaUZiv4ZzcZB0g+CnJ/e1CsqUW5k3ql 3QeIEoi/TWrQH7IBfyBJXBlXU/tnd4+40FGhN/z3eunYwifgjU2dcLPnbVHgmWEzRj1B O6sYG2JEp5/2nUwMx6XFp4GBnK1+LQ+QbX+JDgN4goftP5z6O/KAcbzQma2wbxScZX+f AxUtbqEkoyj0XoAKb+Tt9OXyxAsTyh/KxWVv5Tx3qFTOmuWfBEyis9OGjCR7PcH1zSy7 U+ZQ== X-Gm-Message-State: AAQBX9d3rr65R35QEQPmK1j7AAEC94vvh+W/ejlTRsrko1fp0VjYAuWR 7gbHcG858Z2FSzv1F9nKvidYsmJrnFmacr29a/iMGh9kGYdz3Ggi+qdAIFW/MFxnPVOmY7oC0DG yGxVqHDEt+rw2E8I7TrouVVhhqw0w X-Received: by 2002:a05:600c:3659:b0:3f0:3ab2:a7e5 with SMTP id y25-20020a05600c365900b003f03ab2a7e5mr8649433wmq.34.1682354656889; Mon, 24 Apr 2023 09:44:16 -0700 (PDT) X-Google-Smtp-Source: AKy350bBk8dJUQyWsEOHWwRWp7uQJgWfYVIhS9DgQpvLv1ecV4OCPifMiqCXFYXRMJtTMMtWcpUcSQ== X-Received: by 2002:a05:600c:3659:b0:3f0:3ab2:a7e5 with SMTP id y25-20020a05600c365900b003f03ab2a7e5mr8649410wmq.34.1682354656523; Mon, 24 Apr 2023 09:44:16 -0700 (PDT) Date: Mon, 24 Apr 2023 12:44:12 -0400 From: "Michael S. Tsirkin" To: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org, jasowang@redhat.com, mst@redhat.com, cohuck@redhat.com, sgarzare@redhat.com, stefanha@redhat.com, nrupal.jani@intel.com, Piotr.Uminski@intel.com, hang.yuan@intel.com Cc: virtio@lists.oasis-open.org, Jiri Pirko , Zhu Lingshan , pasic@linux.ibm.com, Shahaf Shuler , Parav Pandit , Max Gurtovoy Message-ID: MIME-Version: 1.0 X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: [virtio-dev] [PATCH v12 00/10] Introduce device group and device management comments on previous one have all been minor, so I hope this means we are close to merging this. Change log: since 11: addressed lots of comments, all minor. consistency with outstanding number->index and queue->enqueue work i did not intentionally drop any reviewed-by tags as all changes are minor - if yours is missing it is because I forgot to record it, sorry one "breaking" change in response to stefan's comment: in patch 5, num_queues has been specified not to include admin queues: just regular ones. since v10: addressed lots of comments by Jiri, Stefan. Cornelia, Lngshan, Parav, Max since v9: addressed comments by Parav, Max, Cornelia, David and Zhu Lingshan: added link to errno header from Linux rename _MEM to _MEMBER admin vq num is zero based clarify who sends commands where minor english tweaks clarify command length specify interaction with sriov capability correct commit log - NumVFs can be 0 i could not decide what should happen when VFs are disabled. for now did not specify. since v8: addressed comments by Cornelia - as we agreed on list since v7: make high level error codes match linux, with virtio specific codes in a separate field renamed _ACCEPT to _USE since that's what it does clarified forward compatibility and non pci transports support multiple admin vqs conformance statements lots of changes all over the place to I changed author from Max to myself. Don't need to take credit but also don't want to blame Max for my mistakes. since v6: - removed some extentions intended for future use. We'll do them when we get there. - brought back command list query from v5 in a simplified form - it's here to address the case where a single parent can address multiple groups, such as PF addressing transport vq and sriov vfs. - attempt to make terminology more formal. In particular a term for whoever controls the group. I am still going back and forth between "parent" and "owner" - owner might be better after all since it will work if we ever have a self group. For now it's parent. TODO (maybe?) - probably ok to defer until this part is upstream: Add "all members" member id. Add commands for MSI, feature discovery. Add commands for transport vq. My intent is to try and support both SR-IOV and SIOV usecases with the same structure and maybe even the same VQ. For example, it might make sense to split creating/destroying SIOV devices from the transport passing data from the guest - the driver would then not negotiate VIRTIO_F_SR_IOV (which then means auto-provisioning). More ideas for use-cases: virtio VF features query and configuration space provisioning virtio VF resource (queues, msix vectors count) provisioning Future directions (shouldn't block this patch) - aborting commands - left for later. or is vq reset enough? - should we rename structures from admin to group admin? Michael S. Tsirkin (10): virtio: document forward compatibility guarantees admin: introduce device group and related concepts admin: introduce group administration commands admin: introduce virtio admin virtqueues pci: add admin vq registers to virtio over pci mmio: document ADMIN_VQ as reserved ccw: document ADMIN_VQ as reserved admin: command list discovery admin: conformance clauses ccw: document more reserved features admin.tex | 587 +++++++++++++++++++++++++++++++++++++++++++++++ content.tex | 121 +++++++++- introduction.tex | 3 + 3 files changed, 709 insertions(+), 2 deletions(-) create mode 100644 admin.tex -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org