From: Jie Deng <jie.deng@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org
Subject: Re: [virtio-comment] [PATCH] virtio-i2c: add the device specification
Date: Fri, 23 Oct 2020 15:03:43 +0800 [thread overview]
Message-ID: <e43a65c2-c7e4-18ab-e0f1-55bf3e324c5a@intel.com> (raw)
In-Reply-To: <20201022081313-mutt-send-email-mst@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
On 2020/10/22 20:15, Michael S. Tsirkin wrote:
> On Thu, Oct 22, 2020 at 03:45:16PM +0800, Jie Deng wrote:
>
> does "use the message" mean? What message?
>> I mean the "addr", "flags" , "len " and "buf " in "virtio_i2c_req" here.
>> I will describe it more precisely in v2.
>>
>> Thanks.
>
> Right. For example it is very unclear what does the
> buffer map to. a single i2c_msg? then do we not need STOP
> etc etc ... ?
>
Yes. virtio_i2c_req is just a wrap of i2c_msg.
I have updated the v2 hoping that the description will look more precise.
Thanks.
[-- Attachment #2: Type: text/html, Size: 1310 bytes --]
prev parent reply other threads:[~2020-10-23 7:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 2:49 [virtio-comment] [PATCH] virtio-i2c: add the device specification Jie Deng
2020-10-21 12:08 ` Michael S. Tsirkin
2020-10-22 7:45 ` Jie Deng
2020-10-22 12:15 ` Michael S. Tsirkin
2020-10-23 7:03 ` Jie Deng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e43a65c2-c7e4-18ab-e0f1-55bf3e324c5a@intel.com \
--to=jie.deng@intel.com \
--cc=mst@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox