Discussion of the implementations of VIRTIO specification
 help / color / mirror / Atom feed
From: Heng Qi <hengqi@linux.alibaba.com>
To: virtio-dev@lists.oasis-open.org
Cc: Jason Wang <jasowang@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [virtio-dev] Re: [PATCH 1/2] virtio_net: fix syntax errors
Date: Wed, 9 Nov 2022 19:35:14 +0800	[thread overview]
Message-ID: <ed7bbb08-afea-0383-6feb-eb434a69e070@linux.alibaba.com> (raw)
In-Reply-To: <20221109113257.120297-2-hengqi@linux.alibaba.com>

Please ignore this email.

Thanks.

在 2022/11/9 下午7:32, Heng Qi 写道:
> From: Heng Qi <henqqi@linux.alibaba.com>
>
> \field{hash_types} can contain multiple bitmasks.
>
> Signed-off-by: Heng Qi <henqqi@linux.alibaba.com>
> Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> ---
>   content.tex | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/content.tex b/content.tex
> index e863709..6fabf1d 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -3210,7 +3210,7 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device
>   The next field, \field{supported_hash_types} only exists if the device supports hash calculation,
>   i.e. if VIRTIO_NET_F_RSS or VIRTIO_NET_F_HASH_REPORT is set.
>   
> -Field \field{supported_hash_types} contains the bitmask of supported hash types.
> +Field \field{supported_hash_types} contains the bitmasks of supported hash types.
>   See \ref{sec:Device Types / Network Device / Device Operation / Processing of Incoming Packets / Hash calculation for incoming packets / Supported/enabled hash types} for details of supported hash types.
>   
>   \devicenormative{\subsubsection}{Device configuration layout}{Device Types / Network Device / Device configuration layout}
> @@ -4369,7 +4369,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
>       u8 hash_key_data[hash_key_length];
>   };
>   \end{lstlisting}
> -Field \field{hash_types} contains a bitmask of allowed hash types as
> +Field \field{hash_types} contains bitmasks of allowed hash types as
>   defined in
>   \ref{sec:Device Types / Network Device / Device Operation / Processing of Incoming Packets / Hash calculation for incoming packets / Supported/enabled hash types}.
>   Initially the device has all hash types disabled and reports only VIRTIO_NET_HASH_REPORT_NONE.
> @@ -4398,7 +4398,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
>       u8 hash_key_data[hash_key_length];
>   };
>   \end{lstlisting}
> -Field \field{hash_types} contains a bitmask of allowed hash types as
> +Field \field{hash_types} contains bitmasks of allowed hash types as
>   defined in
>   \ref{sec:Device Types / Network Device / Device Operation / Processing of Incoming Packets / Hash calculation for incoming packets / Supported/enabled hash types}.
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  parent reply	other threads:[~2022-11-09 11:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09 11:32 [virtio-dev] [PATCH 1/2] virtio_net: fix syntax errors Heng Qi
2022-11-09 11:32 ` [virtio-dev] [PATCH 2/2] virtio_net: support inner header hash for GRE-encapsulated packets Heng Qi
2022-11-09 11:35 ` Heng Qi [this message]
2022-11-09 13:23   ` [virtio-dev] Re: [PATCH 1/2] virtio_net: fix syntax errors Michael S. Tsirkin
2022-11-09 13:38     ` Heng Qi
2022-11-09 13:41       ` Michael S. Tsirkin
2022-11-09 13:20 ` Michael S. Tsirkin
2022-11-09 13:50   ` Heng Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed7bbb08-afea-0383-6feb-eb434a69e070@linux.alibaba.com \
    --to=hengqi@linux.alibaba.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox