[virtio-dev] Re: [PATCH] virtio-network: Fix spelling errors

[David Edmondson <david.edmondson@oracle.com>]

On Saturday, 2022-12-24 at 20:13:35 +02, Parav Pandit wrote:
> Fix two spelling errors in the virtio network device specification.
>
> This patch is on top of change of [1].
>
> [1] https://lists.oasis-open.org/archives/virtio-dev/202212/msg00042.html
>
> Signed-off-by: Parav Pandit <parav@nvidia.com>

Reviewed-by: David Edmondson <david.edmondson@oracle.com>

> ---
>  virtio-network.tex | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/virtio-network.tex b/virtio-network.tex
> index 92e3906..28ed343 100644
> --- a/virtio-network.tex
> +++ b/virtio-network.tex
> @@ -331,7 +331,7 @@ \subsection{Device Initialization}\label{sec:Device Types / Network Device / Dev
>    Otherwise, the driver assumes it's active.
>
>  \item A performant driver would indicate that it will generate checksumless
> -  packets by negotating the VIRTIO_NET_F_CSUM feature.
> +  packets by negotiating the VIRTIO_NET_F_CSUM feature.
>
>  \item If that feature is negotiated, a driver can use TCP segmentation or UDP
>    segmentation/fragmentation offload by negotiating the VIRTIO_NET_F_HOST_TSO4 (IPv4
> @@ -1062,7 +1062,7 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
>  \begin{itemize}
>  \item VIRTIO_NET_CTRL_RX_PROMISC turns promiscuous mode on and
>  off. The command-specific-data is one byte containing 0 (off) or
> -1 (on). If promiscous mode is on, the device SHOULD receive all
> +1 (on). If promiscuous mode is on, the device SHOULD receive all
>  incoming packets.
>  This SHOULD take effect even if one of the other modes set by
>  a VIRTIO_NET_CTRL_RX class command is on.
-- 
Oh by the way, which one's Pink?

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org