From: David Edmondson <david.edmondson@oracle.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: virtio-dev@lists.oasis-open.org, jasowang@redhat.com,
mst@redhat.com, hengqi@linux.alibaba.com, parav@nvidia.com,
virtio-comment@lists.oasis-open.org
Subject: Re: [virtio-comment] [PATCH v3] virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature
Date: Wed, 15 Feb 2023 16:56:07 +0000 [thread overview]
Message-ID: <m2wn4ix3vn.fsf@oracle.com> (raw)
In-Reply-To: <CAJs=3_B9GNpgzj-75mhTm1CtVwa5JfhLzqzRjxD+bsinHOLVZA@mail.gmail.com>
On Wednesday, 2023-02-15 at 18:45:14 +02, Alvaro Karsz wrote:
>> > +\begin{note}
>> > +In general, these commands are best-effort: spurious notifications could still arrive.
>> > +\end{note}
>>
>> This is quite vague. How about:
>>
>> The behaviour of the device in response to these commands is
>> best-effort: the device may generate notifications more frequently than
>> specified, for example after less than \field{max_packets} packets have
>> been processed or less than \field{usecs} usecs time has elapsed.
>>
>
> On second thought, this may be a little confusing.
> The device can send a notification before processing max_packets
> packets, if usecs elapsed (and vice versa).
> So it should be "less than \field{max_packets} packets have been
> processed AND less than \field{usecs} usecs ..."
>
> How about dropping the example?
Given Parav's comment as well, drop the example, yes.
--
Don't worry, Mary, cause I'm taking care of Danny, and he's taking care of me.
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
prev parent reply other threads:[~2023-02-15 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 9:54 [virtio-comment] [PATCH v3] virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature Alvaro Karsz
2023-02-15 11:42 ` [virtio-dev] " Michael S. Tsirkin
2023-02-15 13:41 ` [virtio-comment] " Alvaro Karsz
2023-02-15 13:43 ` [virtio-comment] " David Edmondson
2023-02-15 16:19 ` [virtio-dev] " Alvaro Karsz
2023-02-15 16:43 ` Parav Pandit
2023-02-15 16:45 ` [virtio-dev] " Alvaro Karsz
2023-02-15 16:56 ` David Edmondson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wn4ix3vn.fsf@oracle.com \
--to=david.edmondson@oracle.com \
--cc=alvaro.karsz@solid-run.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox