From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 13 Apr 2023 11:48:24 -0400 From: "Michael S. Tsirkin" Message-ID: <20230413105448-mutt-send-email-mst@kernel.org> References: <20230411150515.14020-1-hreitz@redhat.com> <20230411150515.14020-2-hreitz@redhat.com> <20230412205138.GA2813183@fedora> <0ca69a92-49ab-223e-b737-9d8655883f38@redhat.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: Re: [Virtio-fs] [PATCH 1/4] vhost: Re-enable vrings after setting features List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anton Kuchin Cc: Stefan Hajnoczi , Hanna Czenczek , Stefan Hajnoczi , qemu-devel@nongnu.org, virtio-fs@redhat.com, German Maglione , Juan Quintela , Stefano Garzarella , Roman Kagan , Maxime Coquelin , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau On Thu, Apr 13, 2023 at 05:24:36PM +0300, Anton Kuchin wrote: > But is there a valid use-case for logging some dirty memory but not all? > I can't understand if this is a feature or a just flaw in specification. IRC the use-case originally conceived was for shadow VQs. If you use shadow VQs the VQ access by backend does not change memory since shadow VQ is not in memory. Not a practical concern right now but there you have it. -- MST