From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 10 Jul 2023 16:15:36 -0400 From: "Michael S. Tsirkin" Message-ID: <20230710161447-mutt-send-email-mst@kernel.org> References: <20230710153522.3469097-1-alex.bennee@linaro.org> <20230710153522.3469097-8-alex.bennee@linaro.org> MIME-Version: 1.0 In-Reply-To: <20230710153522.3469097-8-alex.bennee@linaro.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Subject: Re: [Virtio-fs] [PATCH v3 07/20] virtio: add vhost-user-base and a generic vhost-user-device List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: qemu-devel@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Jason Wang , Viresh Kumar , Raphael Norwitz , Paolo Bonzini , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , qemu-block@nongnu.org, Eric Blake , Mark Cave-Ayland , Kevin Wolf , Markus Armbruster , Gerd Hoffmann , Mathieu Poirier , Hanna Reitz , Erik Schilling , "Gonglei (Arei)" , Eduardo Habkost , Fam Zheng , virtio-fs@redhat.com, Stefan Hajnoczi > +static const TypeInfo vud_info = { > + .name = TYPE_VHOST_USER_DEVICE, > + .parent = TYPE_VHOST_USER_BASE, > + .instance_size = sizeof(VHostUserBase), > + .class_init = vud_class_init, > + .class_size = sizeof(VHostUserBaseClass), I wish you didn't tie the refactoring in with new functionality. I applied but blocked creating these for now with: Subject: [PATCH] vhost-user-device: block creating instances Message-Id: block this until we are ready to commit to this command line. Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost-user-device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/vhost-user-device.c b/hw/virtio/vhost-user-device.c index 2b028cae08..ded97b6d70 100644 --- a/hw/virtio/vhost-user-device.c +++ b/hw/virtio/vhost-user-device.c @@ -369,6 +369,7 @@ static const TypeInfo vud_info = { .instance_size = sizeof(VHostUserBase), .class_init = vud_class_init, .class_size = sizeof(VHostUserBaseClass), + .abstract = true }; static void vu_register_types(void) -- MST